refactor(ui): remove styles already supplied by EMCN controls - #7979
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product controls repeated classes already supplied by their active EMCN Button/Chip variants. Remove those redundant classes while preserving custom styling, variants, labels, handlers, and rendered content. For example, small ghost table-filter buttons retain the same vertical padding and text colour through EMCN instead of repeating
py-1andtext-[var(--text-secondary)]locally.This completes the reported redundant-style category: 66 occurrences at 50 control locations, resolved through 41 class-string edits across 25 product files. Shared constants account for several findings; all 10 consumers of the auth-button constant were checked to retain
fullWidth, including the dynamic SSO wrapper. The branch follows merged PRs #7975 and #7977 and targetsstaging.Validation:
git diff --checkpass.All linter code, validation scripts, audit reports, and dependency installation remain outside the PR. Existing presentation exclusions and unrelated styling findings are unchanged in scope.