Skip to content

fix(settings): stabilize group search and modal dropdowns - #7980

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/permission-groups-stable-search
Sep 18, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/permission-groups-stable-search

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep search above the view switch across Permission Groups and every Credential Groups tab, with independent search values and consistent loading/error states.
  • Add bounded request search by item, requester name, and email before pagination; preserve complete provider/grant payloads when filtering the UI.
  • Limit dropdowns inside dialogs to 240px so long lists can fit below their fields, retain viewport collision handling, and announce required/invalid field states through accessible descriptions.
  • Align request sections, pagination, empty states, and modal hints with shared Settings components.

Type of Change

  • Bug fix

Testing

  • Focused tests passed, including local PostgreSQL search, pagination, scope, and wildcard checks; 56 dropdown/modal tests passed after the review correction.
  • Browser checks with real components and fixture data: stable switch positions across all tabs, restored searches, modal dropdown scrolling/selection, Escape/focus, and a short viewport.
  • App and EMCN type checks, lint, 46 repo audits (including API boundary validation), block registry audit, and docs manifest check passed.
  • Completed all eight cleanup passes.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 18, 2026 7:58pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule failures identified.

Summary

This PR stabilizes Settings search state and layout across permission groups, credential groups, and organization access requests while improving modal dropdown sizing and accessibility.

  • Adds independent URL-backed search values for relevant Settings tabs and keeps the shared search field stable while switching views.
  • Adds bounded, scoped organization-request search across target labels and requester identities before pagination.
  • Preserves complete provider and workspace-grant payloads while filtering displayed rows.
  • Limits modal dropdown height according to available viewport space and forwards field descriptions through shared dropdown controls.
  • Aligns loading, error, pagination, and empty states with shared Settings components.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Input[Settings search input] --> URL[URL-backed search state]
  URL -->|Permission/Credential groups| ClientFilter[Client-side row filtering]
  URL -->|Access requests| Debounce[Debounced bounded query]
  Debounce --> API[Authorized organization API]
  API --> Scope[Organization and status scope]
  Scope --> Match[Target label or requester match]
  Match --> Page[Pagination]
  Page --> Results[Settings request list]
Loading

Reviews (2) · Last reviewed commit: "fix(emcn): describe dropdown validation ..."

Comment thread packages/emcn/src/components/chip-dropdown/chip-dropdown.tsx

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 22 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/emcn/src/components/chip-dropdown/chip-dropdown.tsx
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 23 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit ed437fc into staging Sep 18, 2026
36 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/permission-groups-stable-search branch September 18, 2026 20:19

This branch was successfully deployed

1 active deployment
Preview 60263f95 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant