Skip to content

fix(connectors): explain disabled settings with tooltips - #7981

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/connector-settings-tooltips
Sep 18, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/connector-settings-tooltips

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Show the locked sync-method explanation in a tooltip on the disabled dropdown.
  • Keep the active-sync explanation in the disabled Save tooltip on both settings pages and connector modals, with a hidden live announcement for assistive technology.
  • Make shared disabled-tooltip wrappers keyboard reachable, shorten the browsing-account hint, and remove routine sync guidance while retaining permission warnings.

Type of Change

  • Bug fix

Testing

  • 202 focused tests passed, including tooltip visibility, keyboard access, disabled actions, and permission-expiry warnings.
  • App and EMCN type checks, lint, all 46 repository audits, block registry and docs-manifest checks passed.
  • Reviewed the desktop preview using the real components with mocked accounts.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 18, 2026 9:00pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding actionable findings.

Summary

This PR improves explanations for disabled connector settings and actions.

  • Adds a disabled sync-method dropdown with an explanatory tooltip.
  • Makes disabled-action tooltip wrappers keyboard reachable while leaving their actions disabled.
  • Preserves blocked-save information in a visually hidden live status region.
  • Simplifies routine connector guidance while retaining permission-expiry warnings.
  • Adds focused regression coverage for keyboard focus, tooltip visibility, disabled activation, and status announcements.

Reviews (2) · Last reviewed commit: "fix(settings): preserve accessible disab..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 7a8f39a into staging Sep 18, 2026
37 of 38 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/connector-settings-tooltips branch September 18, 2026 20:25

This branch was successfully deployed

1 active deployment
Preview 1a69cec3 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant