refactor(ui): centralize document file-type icons in EMCN - #7984
Merged
Merged
Conversation
Contributor
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The document/file-type icon family is defined in the app instead of EMCN. Move all 14 existing SVG components into
@sim/emcn/iconsand update direct consumers, including the existing landing previews. KeepgetDocumentIconin the app with its MIME-type/extension selection order and upload-validation dependencies unchanged.Preserve the complete icon functions: drawings, view boxes, strokes, PDF lettering, SVG prop forwarding and caller-provided sizes/colors. This is an independent PR against staging and does not depend on #7983.
The diff contains only the icon relocation, exports and import updates. The existing document-icon test changes imports only; no new tests, linter tooling, configuration or dependencies are included.
Type of Change
Testing
git diff --checkpassed.Validation uses source and rendered markup comparison; no browser screenshot comparison was performed. Unrelated audit findings and coverage gaps remain outside this file-type icon category.