Skip to content

refactor(ui): centralize product icon-button padding in EMCN #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Sep 18, 2026
Merged

refactor(ui): centralize product icon-button padding in EMCN #7987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .../workspace/[workspaceId]/logs/components/log-details/components/trace-view/trace-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ function DetailCodeSection({
</span>
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={goToPreviousMatch}
disabled={matchCount === 0}
aria-label='Previous match'
Expand All @@ -576,7 +576,7 @@ function DetailCodeSection({
</Button>
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={goToNextMatch}
disabled={matchCount === 0}
aria-label='Next match'
Expand All @@ -585,7 +585,7 @@ function DetailCodeSection({
</Button>
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={closeSearch}
aria-label='Close search'
>
Expand Down Expand Up @@ -1045,7 +1045,7 @@ export const TraceView = memo(function TraceView({ traceSpans, runCostDollars }:
<Button
type='button'
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={() => copyTrace(JSON.stringify(traceSpans, null, 2))}
aria-label='Copy raw trace'
>
Expand All @@ -1065,7 +1065,7 @@ export const TraceView = memo(function TraceView({ traceSpans, runCostDollars }:
<Button
type='button'
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={() => setExpandedNodes(new Set(allIds))}
aria-label='Expand all'
>
Expand All @@ -1079,7 +1079,7 @@ export const TraceView = memo(function TraceView({ traceSpans, runCostDollars }:
<Button
type='button'
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={() => setExpandedNodes(new Set())}
aria-label='Collapse all'
>
Expand Down
14 changes: 7 additions & 7 deletions apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export const WorkflowOutputSection = memo(
</span>
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={goToPreviousMatch}
disabled={matchCount === 0}
aria-label='Previous match'
Expand All @@ -242,7 +242,7 @@ export const WorkflowOutputSection = memo(
</Button>
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={goToNextMatch}
disabled={matchCount === 0}
aria-label='Next match'
Expand All @@ -251,7 +251,7 @@ export const WorkflowOutputSection = memo(
</Button>
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={closeSearch}
aria-label='Close search'
>
Expand Down Expand Up @@ -838,7 +838,7 @@ export const LogDetails = memo(function LogDetails({
<Tooltip.Trigger asChild>
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={() => onRetryExecution?.()}
disabled={isRetryPending}
aria-label='Retry execution'
Expand All @@ -851,7 +851,7 @@ export const LogDetails = memo(function LogDetails({
)}
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={() => hasPrev && onNavigatePrev?.()}
disabled={!hasPrev}
aria-label='Previous log'
Expand All @@ -860,14 +860,14 @@ export const LogDetails = memo(function LogDetails({
</Button>
<Button
variant='ghost'
className='p-1!'
iconPadding='sm'
onClick={() => hasNext && onNavigateNext?.()}
disabled={!hasNext}
aria-label='Next log'
>
<ChevronUp className='size-[14px] rotate-180' />
</Button>
<Button variant='ghost' className='p-1!' onClick={onClose} aria-label='Close'>
<Button variant='ghost' iconPadding='sm' onClick={onClose} aria-label='Close'>
<X className='size-[14px]' />
</Button>
</div>
Expand Down
3 changes: 2 additions & 1 deletion ...workspace/[workspaceId]/settings/components/workflow-mcp-servers/workflow-mcp-servers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,8 @@ function ServerDetailView({
variant='ghost'
aria-label={copiedConfig ? 'Configuration copied' : 'Copy configuration'}
onClick={() => handleCopyConfig(server.isPublic, server.name)}
className='-my-1.5 p-1.5!'
iconPadding='md'
className='-my-1.5'
>
{copiedConfig ? (
<Check className='size-[14px]' />
Expand Down
3 changes: 2 additions & 1 deletion ...[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-config-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,8 @@ function ColumnConfigBody({
variant='ghost'
size='sm'
onClick={onClose}
className='size-7 p-1!'
iconPadding='sm'
className='size-7'
aria-label='Close'
>
<X className='size-[14px]' />
Expand Down
2 changes: 1 addition & 1 deletion ...space/[workspaceId]/tables/[tableId]/components/enrichment-details/enrichment-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ export function EnrichmentDetails({
<div className='flex h-full flex-col px-3.5 pt-3'>
<div className='flex items-center justify-between'>
<h2 className='text-[var(--text-primary)] text-sm'>Enrichment Details</h2>
<Button variant='ghost' className='p-1!' onClick={onClose} aria-label='Close'>
<Button variant='ghost' iconPadding='sm' onClick={onClose} aria-label='Close'>
<X className='size-[14px]' />
</Button>
</div>
Expand Down
6 changes: 4 additions & 2 deletions ...space/[workspaceId]/tables/[tableId]/components/enrichments-sidebar/enrichment-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,8 @@ export function EnrichmentConfig({
variant='ghost'
size='sm'
onClick={onBack}
className='size-7 flex-none p-1!'
iconPadding='sm'
className='size-7 flex-none'
aria-label='Back to enrichments'
>
<ArrowLeft className='size-[14px]' />
Expand All @@ -249,7 +250,8 @@ export function EnrichmentConfig({
variant='ghost'
size='sm'
onClick={onClose}
className='size-7 flex-none p-1!'
iconPadding='sm'
className='size-7 flex-none'
aria-label='Close'
>
<X className='size-[14px]' />
Expand Down
6 changes: 4 additions & 2 deletions ...ace/[workspaceId]/tables/[tableId]/components/enrichments-sidebar/enrichments-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ function EnrichmentsSidebarBody({
variant='ghost'
size='sm'
onClick={onClose}
className='size-7 flex-none p-1!'
iconPadding='sm'
className='size-7 flex-none'
aria-label='Close'
>
<X className='size-[14px]' />
Expand Down Expand Up @@ -123,7 +124,8 @@ function EnrichmentsSidebarBody({
variant='ghost'
size='sm'
onClick={onClose}
className='size-7 flex-none p-1!'
iconPadding='sm'
className='size-7 flex-none'
aria-label='Close'
>
<X className='size-[14px]' />
Expand Down
3 changes: 2 additions & 1 deletion ...orkspace/[workspaceId]/tables/[tableId]/components/select-field/select-options-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ export function SelectOptionsEditor({ options, onChange }: SelectOptionsEditorPr
variant='ghost'
size='sm'
onClick={() => remove(option.id)}
className='size-7 shrink-0 p-1!'
iconPadding='sm'
className='size-7 shrink-0'
aria-label={`Remove ${option.name || 'option'}`}
>
<X className='size-[12px]' />
Expand Down
3 changes: 2 additions & 1 deletion ...sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-filter/table-filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,8 @@ const FilterRuleRow = memo(function FilterRuleRow({
variant='ghost'
size='sm'
onClick={() => onRemove(rule.id)}
className='size-7 shrink-0 p-1!'
iconPadding='sm'
className='size-7 shrink-0'
aria-label='Remove filter'
>
<X className='size-[12px]' />
Expand Down
6 changes: 4 additions & 2 deletions ...workspace/[workspaceId]/tables/[tableId]/components/workflow-sidebar/workflow-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,8 @@ export function WorkflowSidebarBody({
variant='ghost'
size='sm'
onClick={onBack}
className='size-7 flex-none p-1!'
iconPadding='sm'
className='size-7 flex-none'
aria-label='Back to enrichments'
>
<ArrowLeft className='size-[14px]' />
Expand All @@ -651,7 +652,8 @@ export function WorkflowSidebarBody({
variant='ghost'
size='sm'
onClick={onClose}
className='size-7 flex-none p-1!'
iconPadding='sm'
className='size-7 flex-none'
aria-label='Close'
>
<X className='size-[14px]' />
Expand Down
6 changes: 4 additions & 2 deletions apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,8 @@ export function Chat() {
<Button
aria-label='Chat actions'
variant='ghost'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
onClick={(e) => e.stopPropagation()}
>
<MoreVertical className='size-[14px]' />
Expand Down Expand Up @@ -996,7 +997,8 @@ export function Chat() {
<Button
aria-label='Close chat'
variant='ghost'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
onClick={handleClose}
>
<X className='size-[16px]' />
Expand Down
9 changes: 6 additions & 3 deletions ...flowId]/components/panel/components/deploy/components/deploy-modal/components/api/api.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,8 @@ console.log(limits);`
variant='ghost'
onClick={() => handleCopy('sync', getSyncCommand())}
aria-label='Copy command'
className='-my-1.5 p-1.5!'
iconPadding='md'
className='-my-1.5'
>
{copied.sync ? <Check className='size-3' /> : <Clipboard className='size-3' />}
</Button>
Expand Down Expand Up @@ -508,7 +509,8 @@ console.log(limits);`
variant='ghost'
onClick={() => handleCopy('stream', getStreamCommand())}
aria-label='Copy command'
className='-my-1.5 p-1.5!'
iconPadding='md'
className='-my-1.5'
>
{copied.stream ? <Check className='size-3' /> : <Clipboard className='size-3' />}
</Button>
Expand Down Expand Up @@ -548,7 +550,8 @@ console.log(limits);`
variant='ghost'
onClick={() => handleCopy('async', getAsyncCommand())}
aria-label='Copy command'
className='-my-1.5 p-1.5!'
iconPadding='md'
className='-my-1.5'
>
{copied.async ? <Check className='size-3' /> : <Clipboard className='size-3' />}
</Button>
Expand Down
4 changes: 2 additions & 2 deletions ...anel/components/deploy/components/deploy-modal/components/general/components/versions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ export function Versions({
<Button
aria-label={v.description ? 'Edit description' : 'Add description'}
variant='ghost'
iconPadding='sm'
className={cn(
'p-1!',
!v.description &&
'text-[var(--text-quaternary)] hover-hover:text-[var(--text-tertiary)]'
)}
Expand Down Expand Up @@ -359,7 +359,7 @@ export function Versions({
<Button
aria-label='Version actions'
variant='ghost'
className='p-1!'
iconPadding='sm'
disabled={isPromotingVersion}
onClick={(e) => e.stopPropagation()}
>
Expand Down
30 changes: 20 additions & 10 deletions ...[workspaceId]/w/[workflowId]/components/terminal/components/output-panel/output-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={handleCloseSearchClick}
aria-label='Close search'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
>
<X className='size-[14px]' />
</Button>
Expand All @@ -357,7 +358,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={handleSearchClick}
aria-label='Search in output'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
>
<Search className='size-[14px]' />
</Button>
Expand All @@ -375,7 +377,8 @@ export const OutputPanel = React.memo(function OutputPanel({
<Button
variant='ghost'
aria-label='Component Playground'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
>
<Palette className='size-[14px]' />
</Button>
Expand All @@ -393,7 +396,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={handleCopyClick}
aria-label='Copy output'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
>
{showCopySuccess ? (
<Check className='size-[14px]' />
Expand All @@ -414,7 +418,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={handleExportConsole}
aria-label='Export console CSV'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
>
<Download className='size-[14px]' />
</Button>
Expand All @@ -429,7 +434,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={handleClearConsole}
aria-label='Clear console'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
>
<Trash className='size-[14px]' />
</Button>
Expand All @@ -446,7 +452,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={(e) => e.stopPropagation()}
aria-label='Terminal options'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
>
<MoreHorizontal className='size-[14px]' />
</Button>
Expand Down Expand Up @@ -511,7 +518,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={goToPreviousMatch}
aria-label='Previous match'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
disabled={matchCount === 0}
>
<ArrowUp className='size-[14px]' />
Expand All @@ -520,7 +528,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={goToNextMatch}
aria-label='Next match'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
disabled={matchCount === 0}
>
<ArrowDown className='size-[14px]' />
Expand All @@ -529,7 +538,8 @@ export const OutputPanel = React.memo(function OutputPanel({
variant='ghost'
onClick={closeOutputSearch}
aria-label='Close search'
className='-m-1.5 p-1.5!'
iconPadding='md'
className='-m-1.5'
>
<X className='size-[14px]' />
</Button>
Expand Down
Loading
Loading