refactor(ui): centralize overlay action buttons in EMCN - #7990
BillLeoutsakosvl346 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
@greptileai please re-review PR #7990 at commit 7a463bc. Added four focused OverlayActionButton test cases following the existing action-button conventions: the three migrated appearances (both sizes and hover treatments, with Button class precedence), plus native ref/prop/event forwarding through Tooltip and disabled-click suppression. All 347 EMCN tests, type checks, repository lint and API validation pass. Runtime source is unchanged. |
|
@greptileai @cubic-dev-ai Please review the current head. The requested overlay-button test coverage is present and all three focused tests pass. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Before / after visual comparisonCopy, copied, search and preview overlay actions reuse the common Button treatment. Within each numbered tile: first control = before; second control = after. Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage. Current PR head checked at posting: |
f1e45e4 to
e5c205a
Compare
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
e5c205a to
9c2953d
Compare
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |


Summary
Nine product Copy, Search and Expand buttons repeat transparent overlay styling in log details, workflow previews and the deployment preview. Add EMCN
OverlayActionButton, built on the existing Button, and migrate all nine locations across four consumer files.The component owns its 20px/28px geometry, border, background blur and one adaptive hover treatment: surface-3 in light mode and surface-5 in dark mode. The four workflow-preview actions previously used surface-4 on hover; their hover fill changes from #f5f5f5 to #f7f7f7 in light mode and #292929 to #363636 in dark mode. Resting appearance, sizes, corners and behavior stay unchanged. The canonical
--bordertoken replaces its equivalent--border-1alias.Product code keeps positioning, icons, copy feedback, tooltips, labels and handlers. The specialized component excludes inherited styling props that cannot meaningfully affect its geometry. Existing Button, landing pages and global CSS are unchanged. Audit tooling and screenshots remain outside this PR.
Validation