Consolidate EMCN controls and redundant styling options - #7998
BillLeoutsakosvl346 wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
There was a problem hiding this comment.
All reported issues were addressed across 87 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
|
@greptileai @cubic-dev-ai Please review the current head; the previous scored reviews cover an earlier commit. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Co-authored-by: Bill Leoutsakos <billleoutsakos@Mac.localdomain>
Consolidates overlapping EMCN controls while preserving product layouts, selection values, form behavior, and marketing treatments.
ChipSelectthe single menu-selection API, supporting rich labels, grouped/searchable options, typed single/multiple selection, trigger refs, and field accessibility. Preserve caller-specific menu width, modal behavior, empty-selection semantics, and selection indicators.ChipButtonGroupand itsChipSwitchadapter. Remove redundant styling dimensions and unused Button, Checkbox, and Badge choices.Intentional visual differences: multiple-selection menus use checkbox rows; segmented groups use zero gap; former large badges use medium sizing; table bulk actions use the adaptive dark fill; migrated fields use chip corners and surfaces while retaining required height constraints. Marketing single-selection checkmarks, form heights, and pricing-toggle treatment are retained.
Validation: all 26 workspace type checks and lint checks, import-specifier checks, API validation, 350 EMCN tests, and 91 relevant consumer tests passed. The migration audit found zero retired-API references or parse failures; all 37 dynamic references were reviewed. Representative product and marketing flows received browser review, including table execution and re-execution. Browser coverage is not exhaustive.