Skip to content

Consolidate EMCN controls and redundant styling options - #7998

Open
BillLeoutsakosvl346 wants to merge 8 commits into
stagingfrom
codex/emcn-consolidation
Open

BillLeoutsakosvl346 wants to merge 8 commits into
stagingfrom
codex/emcn-consolidation

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Consolidates overlapping EMCN controls while preserving product layouts, selection values, form behavior, and marketing treatments.

  • Make ChipSelect the single menu-selection API, supporting rich labels, grouped/searchable options, typed single/multiple selection, trigger refs, and field accessibility. Preserve caller-specific menu width, modal behavior, empty-selection semantics, and selection indicators.
  • Share one Radix segmented-control implementation through ChipButtonGroup and its ChipSwitch adapter. Remove redundant styling dimensions and unused Button, Checkbox, and Badge choices.
  • Exclude inherited generic sizing props from specialized action buttons that own their geometry.
  • Use existing chip controls for ordinary auth/credential fields and deployment descriptions, retain specialized editing surfaces, and reuse shared chip and dropdown styling definitions.

Intentional visual differences: multiple-selection menus use checkbox rows; segmented groups use zero gap; former large badges use medium sizing; table bulk actions use the adaptive dark fill; migrated fields use chip corners and surfaces while retaining required height constraints. Marketing single-selection checkmarks, form heights, and pricing-toggle treatment are retained.

Validation: all 26 workspace type checks and lint checks, import-specifier checks, API validation, 350 EMCN tests, and 91 relevant consumer tests passed. The migration audit found zero retired-API references or parse failures; all 37 dynamic references were reviewed. Representative product and marketing flows received browser review, including table execution and re-execution. Browser coverage is not exhaustive.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 3:32am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The current PR appears safe to merge, with no actionable new issue or outstanding previous finding identified.

Summary

This PR consolidates overlapping EMCN controls and styling APIs while migrating consumers to the shared implementations.

  • Makes ChipSelect the canonical menu-selection component, including searchable, grouped, single-select, and multi-select modes.
  • Unifies segmented controls through ChipButtonGroup and the ChipSwitch adapter.
  • Removes redundant visual variants and migrates product, authentication, deployment, settings, and marketing surfaces to the consolidated APIs.
  • Tightens specialized action-button prop types so their fixed geometry remains component-owned.
  • The sole previous finding was manually resolved, and the current implementation also replaces the affected password fields with the shared PasswordInput adornment path.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Consumers[Product and marketing consumers] --> Select[ChipSelect]
  LegacySelection[ChipDropdown and overlapping selection paths] --> Select
  Select --> Single[Single selection]
  Select --> Multi[Multiple selection]
  Select --> Search[Grouped and searchable options]

  SegmentedConsumers[Segmented-control consumers] --> Group[ChipButtonGroup]
  Switch[ChipSwitch adapter] --> Group
  Group --> Radix[Shared Radix radio-group implementation]

  ActionConsumers[Specialized action consumers] --> Bulk[BulkActionButton]
  ActionConsumers --> Composer[ComposerActionButton]
  Bulk --> FixedGeometry[Component-owned geometry]
  Composer --> FixedGeometry
Loading

Reviews (3) · Last reviewed commit: "fix(emcn): exclude generic icon sizing f..."

Comment thread apps/sim/app/f/[token]/public-file-auth.tsx Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 87 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/ee/organization-usage/components/activity-panel.tsx
Comment thread packages/emcn/src/components/chip-select/chip-select.tsx
Comment thread apps/sim/app/f/[token]/public-file-auth.tsx Outdated
Comment thread packages/emcn/src/components/chip/chip-chrome.ts Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 88 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai @cubic-dev-ai Please review the current head; the previous scored reviews cover an earlier commit.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@greptileai @cubic-dev-ai Please review the current head; the previous scored reviews cover an earlier commit.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 88 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Co-authored-by: Bill Leoutsakos <billleoutsakos@Mac.localdomain>

This branch was previously deployed

1 inactive deployment
Preview 4881f6ec Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant