Skip to content

refactor(ui): reuse shared cards for workflow inputs and variables - #8022

Open
BillLeoutsakosvl346 wants to merge 2 commits into
codex/control-fix-collapsible-field-cardsfrom
codex/control-fix-remaining-field-cards
Open

BillLeoutsakosvl346 wants to merge 2 commits into
codex/control-fix-collapsible-field-cardsfrom
codex/control-fix-remaining-field-cards

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Variable assignments, Start/Response fields, and the Variables panel now reuse EMCN's CollapsibleCard instead of maintaining separate header/body markup. Header actions remain separate from the collapse trigger. The shared card supports the existing animated expansion and body attributes, preserving Start's Radix animation, Variables' tighter spacing, and its trigger/content association.

Colors, padding, fields, and handlers are retained. Start header corners consolidate from 3px to 4px; long titles use the existing fade/full-title tooltip treatment instead of ellipsis.

Validation: 346 EMCN tests, 67 relevant consumer tests, all workspace type and lint checks, import resolution, and mandatory API validation passed. An external AST comparison confirms all 20 affected field-control subtrees are unchanged. The scoped six radius findings are removed. Browser comparisons cover both themes, disabled/long-title cases, existing shared-card rendering, action isolation and animated keyboard collapse/reopen. Visual coverage uses isolated components with fixture fields, not live workflow execution.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 20, 2026 1:25am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues identified.

Summary

This PR consolidates workflow input, variable-assignment, and workflow-variable field cards onto the shared EMCN CollapsibleCard component.

  • Extends CollapsibleCard with optional animated expansion and native body attributes.
  • Preserves separate header actions, controlled collapse behavior, and trigger-to-content accessibility linkage.
  • Replaces duplicated card markup in Start/Response fields and variable editors.
  • Adds coverage for animated and non-animated collapse behavior.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Consumers[Workflow input and variable editors] --> Card[Shared CollapsibleCard]
  Card --> Header[Accessible collapse trigger]
  Card --> Actions[Independent header actions]
  Card --> Body[Field controls]
  Card -->|animated| Expandable[Expandable height transition]
  Card -->|non-animated| Conditional[Conditional body rendering]
Loading

Reviews (2) · Last reviewed commit: "refactor(ui): reuse shared cards for wor..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-collapsible-field-cards branch from 416b32f to f3a1d85 Compare September 19, 2026 19:51
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-remaining-field-cards branch from 1d7de93 to b16927a Compare September 19, 2026 19:51
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai @cubic-dev-ai Please review the latest head after the base update. The card changes are unchanged; validation passes on the updated stack.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@greptileai @cubic-dev-ai Please review the latest head after the base update. The card changes are unchanged; validation passes on the updated stack.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant