refactor(ui): share static API and MCP parameter cards - #8027
Open
BillLeoutsakosvl346 wants to merge 4 commits into
Open
BillLeoutsakosvl346 wants to merge 4 commits into
BillLeoutsakosvl346 wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Contributor
Author
|
@cubic-dev-ai Please review the current parameter-card changes. |
Contributor
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
* improvement(ui): share field mode toggles * fix(ui): transition field mode icon colors --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API and MCP parameter editors duplicated the same name/type header and description-card styling. They now use EMCN
FieldCard, which shares its frame and body withCollapsibleCardwhile keeping a non-interactive, always-open header. Existing description controls, values and callbacks are preserved.Colors, borders, corners, body spacing and badge placement stay the same. Long names use the standard fade and full-value tooltip; MCP settings names align to the other cards at 14px instead of 15px, making that header 2.5px shorter in the browser comparison. Existing collapsible cards retain their appearance and behavior.
Validation: all 26 workspace type/lint checks, import-specifier resolution, mandatory API validation, 355 EMCN tests and 45 relevant consumer tests passed. The external conformance audit removes all three targeted findings and adds none. Twelve field-control subtrees are unchanged. Isolated light/dark browser comparisons cover the migrated cards, long labels, actions and keyboard collapse/reopen; live API saves and MCP deployments were not exercised.