Skip to content

fix(ui): align editor subblocks and combobox styling - #8049

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/align-fallback-model-subblocks
Sep 20, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/align-fallback-model-subblocks

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Align fallback-model rows with the editor's compact headers, field spacing, and icon actions.
  • Keep folder, knowledge-base, MCP, and fallback pickers on the existing editor combobox styling so they can migrate together.
  • Preserve editable combobox styling when file controls add clear-button padding.

Type of Change

  • Bug fix

Testing

  • 235 affected tests passed across editor, MCP, fallback-model, and shared combobox suites.
  • App and EMCN type-checks, repository lint, all 47 audits (including API validation), and generated-artifact checks passed.
  • Verified light/dark component previews at narrow editor widths and fallback tuning selection.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 20, 2026 12:53am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The functional changes appear sound, but the explicit requirement to use chip-family selectors must be satisfied before merging.

Findings

  1. P2 Legacy selector components

Summary

This PR restyles fallback-model rows and related editor selectors, replaces chip-family selectors with the shared base combobox, and fixes editable combobox class-name merging.

  • Introduces compact fallback-row headers, icon actions, spacing, and add-control styling.
  • Migrates model, secret, tuning, knowledge-base, MCP, and folder selectors to Combobox.
  • Preserves caller-provided editable-input classes and adds focused DOM coverage.
  • Updates selector and fallback-list tests for the component changes.

Reviews (2) · Last reviewed commit: "fix(ui): keep editor pickers on shared c..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1 waleedlatif1 changed the title fix(ui): align fallback model subblock styling fix(ui): align editor subblocks and combobox styling Sep 20, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit ac24c87 into staging Sep 20, 2026
28 of 29 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/align-fallback-model-subblocks branch September 20, 2026 00:54

This branch was successfully deployed

1 active deployment
Preview faedae93 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant