Skip to content

improvement(ui): reuse avatars for owners and members - #8079

Merged
BillLeoutsakosvl346 merged 1 commit into
codex/control-fix-public-auth-headingsfrom
codex/control-fix-member-avatars
Sep 24, 2026
Merged

BillLeoutsakosvl346 merged 1 commit into
codex/control-fix-public-auth-headingsfrom
codex/control-fix-member-avatars

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Use the existing Avatar family for owner and member photos, initials and failed-image fallback.
  • Give the existing xs size 8px initials centrally. Preserve the 14px footprint, image alt/referrer behavior, other sizes and explicit fallback overrides.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN test suite and relevant existing consumer suites pass.
  • Before/after browser fixtures cover light/dark styling, narrow layouts and the affected interaction patterns. Fixtures are isolated controls, not full authenticated product flows.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 9:12pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding correctness or repository-rule issues.

Summary

Reuses the shared EMCN Avatar family for owner and member images and fallbacks while preserving the existing 14px footprint, image metadata, and initials behavior.

  • Adds size context so AvatarFallback renders 8px initials for xs avatars.
  • Removes redundant 7px overrides from presence avatars.
  • Adds focused coverage for xs, default, and explicitly overridden fallback sizing.

Reviews (4) · Last reviewed commit: "improvement(ui): reuse avatars for owner..."

Comment thread packages/emcn/src/components/avatar/avatar.tsx

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Member/owner avatars reuse Avatar. Failed images now show initials; the photo example shows the normal state.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

The broken-image symbol on the left is intentional: it illustrates the missing fallback that the shared Avatar fixes.

Current PR head checked at posting: daba366cb4.

Before and after: light avatar broken

Additional theme/state comparisons

Before and after: dark avatar broken

Before and after: light avatar photo

Before and after: dark avatar photo

@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from codex/emcn-consolidation to codex/typography-consolidation September 22, 2026 08:18
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Base automatically changed from codex/typography-consolidation to codex/control-fix-public-auth-headings September 22, 2026 17:57
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-public-auth-headings branch from 4d8c337 to f8bafb5 Compare September 22, 2026 20:04
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-member-avatars branch from cfb736e to 1e32037 Compare September 22, 2026 21:10
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346
BillLeoutsakosvl346 merged commit 4491848 into codex/control-fix-public-auth-headings Sep 24, 2026
8 checks passed
BillLeoutsakosvl346 added a commit that referenced this pull request Sep 24, 2026
* improvement(emcn): share larger chip and field geometry

* improvement(ui): share public authentication headings

* improvement(ui): share workflow panel tab buttons (#8072)

* improvement(ui): share workflow panel tab buttons

* improvement(ui): reuse chips for panel selection actions (#8166)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): share account headings and auth control sizing (#8074)

* improvement(ui): share account status headings

* improvement(ui): use shared sizing for auth controls

* refactor(emcn): share invalid OTP slot treatment (#8246)

* Add shared invalid state to EMCN OTP slots

* fix(ui): distinguish OTP verification from resend errors

* test(ui): type OTP input queries as inputs

* test(ui): import OTP test button prop type

* test(ui): use shared logger mock in OTP regression

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* improvement(ui): share missing resource states (#8078)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): reuse avatars for owners and members (#8079)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(ui): adopt exact shared 18px typography token

* fix(ui): preserve panel and auth control semantics

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>
BillLeoutsakosvl346 added a commit that referenced this pull request Sep 24, 2026
* improvement(emcn): share ordinary action geometry in Button

* improvement(emcn): consolidate selection controls and styling options

* test(emcn): read email geometry from the public export

* improvement(emcn): share larger chip and field geometry (#8151)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): use EMCN fields in deployment and setup modals (#8009)

* improvement(emcn): share larger chip and field geometry

* refactor(ui): use EMCN fields in deployment and setup modals

* improvement(ui): reuse chip for PII configuration action (#8173)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): compose horizontal and credential fields in EMCN (#8164)

* improvement(ui): compose horizontal and credential fields in EMCN

* Share deploy chat field error treatment (#8255)

* refactor(ui): share deploy chat field error treatment

* refactor(ui): name deploy error props

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): share knowledge filter headings (#8073)

* improvement(ui): share knowledge filter headings

* improvement(ui): share inline filter and pagination actions (#8163)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): use chip fields in workflow search and replace (#8076)

* improvement(emcn): share larger chip and field geometry

* improvement(ui): use chip fields in workflow search and replace

* fix(ui): use shared centered chip content on chat errors

* improvement(ui): use chips for ordinary product actions (#8081)

* improvement(ui): use chips for ordinary product actions

* improvement(ui): use shared chip alignment

* improvement(ui): use shared search action sizes (#8160)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): reuse chips for custom block upload actions (#8084)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(chat): use native attachment action (#8265)

* fix(chat): use native attachment action

* fix(chat): retain disabled attachment tooltip

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(chat): use EMCN icon button target for attachments

* refactor(ui): centralize destructive ghost button colors in EMCN (#7988)

* improvement(emcn): share larger chip and field geometry

* refactor(ui): use EMCN fields in deployment and setup modals

* refactor(ui): centralize destructive ghost button colors in EMCN

* improvement(ui): use standard knowledge tag icon size

* refactor(ui): consolidate product corner radii

* improvement(ui): reuse chip for PII configuration action (#8173)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): share collapsible workflow field cards (#8017)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): compose horizontal and credential fields in EMCN (#8164)

* improvement(ui): compose horizontal and credential fields in EMCN

* Share deploy chat field error treatment (#8255)

* refactor(ui): share deploy chat field error treatment

* refactor(ui): name deploy error props

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* improvement(ui): share public headings and product typography (#8069)

* improvement(emcn): share larger chip and field geometry

* improvement(ui): share public authentication headings

* improvement(ui): share workflow panel tab buttons (#8072)

* improvement(ui): share workflow panel tab buttons

* improvement(ui): reuse chips for panel selection actions (#8166)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): share account headings and auth control sizing (#8074)

* improvement(ui): share account status headings

* improvement(ui): use shared sizing for auth controls

* refactor(emcn): share invalid OTP slot treatment (#8246)

* Add shared invalid state to EMCN OTP slots

* fix(ui): distinguish OTP verification from resend errors

* test(ui): type OTP input queries as inputs

* test(ui): import OTP test button prop type

* test(ui): use shared logger mock in OTP regression

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* improvement(ui): share missing resource states (#8078)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): reuse avatars for owners and members (#8079)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(ui): adopt exact shared 18px typography token

* fix(ui): preserve panel and auth control semantics

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* fix(ui): preserve shared tag actions and product styling fallbacks

* fix(ui): keep logs filters on canonical chip height

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Waleed <walif6@gmail.com>
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-member-avatars branch September 24, 2026 23:57

This branch was successfully deployed

1 active deployment
Preview — 1e320377 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant