refactor(ui): centralize status colours and slide shadow - #8244
BillLeoutsakosvl346 merged 1 commit into
Conversation
|
@greptile review this PR |
|
@cubic-dev-ai review this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
|
There was a problem hiding this comment.
1 issue found across 6 files
Confidence score: 4/5
- In
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx, the active-status dot may not resolve to its intended color because--color-yellow-500is declared only inside@theme inline; define the referenced color token where it is available to:rootor use a reliably defined token.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx">
<violation number="1" location="apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx:285">
P2: The active-status dot now renders via `var(--chat-status-active)`, but that token is defined in `:root` as `var(--color-yellow-500)`, and `--color-yellow-500: #eab308` is declared only inside `@theme inline` (globals.css lines 62–176). Per the codebase's own comment at globals.css lines 53–59, `@theme inline` substitutes values into utilities instead of declaring `--color-*` on `:root`, and Tailwind v4 does not emit those variables at runtime. So `var(--color-yellow-500)` is unresolved in the `:root` declaration, `--chat-status-active` computes as guaranteed-invalid, and `background-color: var(--chat-status-active)` falls back to `transparent` — the active dot that was `#EAB308` renders invisible. Define the token with a value that exists at runtime, e.g. `--chat-status-active: #eab308;` in globals.css, or declare the palette as real `:root` custom properties instead of `@theme inline` variables.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@greptile review this PR |
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
7dfc317
into
codex/product-usage-chart-colours
Summary
globals.csstokens.Base and design review
Targets the live usage-palette head
ef78d224(#8211). The local diff checker 3.10.6 reports sevencentral-definitionitems for the intentional global token additions and zero new colour-assignment violations. A prior false positive onbox-shadow: var(--shadow-presentation-slide)was corrected and tested in the separate local tooling checkout; that tooling change is not in this product PR. Raw design results remain visible.Validation
Visual comparison
Representative matched captures from the local source-derived fixture. Before uses this PR’s base; after uses this PR’s head. Full light/dark and root-size matrices are retained outside the product branch.
Light · 16px root text · default
Dark · 20px root text · default