Skip to content

fix(ui): compact crowded tabs and layer native browser overlays - #8306

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/compact-tabs-native-overlays
Sep 25, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/compact-tabs-native-overlays

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Size floating resource tabs from available space, shrinking to a compact control minimum before scrolling.
  • Keep overlapping tooltips and menus above the native browser using the existing snapshot lifecycle, with bounded retries, hidden recapture, and cancelable preparation across resize and modal transitions.
  • Add real Electron regression coverage for tab sizing and native browser overlays.

Type of Change

  • Bug fix

Testing

  • Real Electron regression test passed all nine scenarios; inspected tooltip and menu captures.
  • Browser occlusion and native panel regression tests: 20 passed; regressions verified to fail before their fixes.
  • All workspace type checks, full lint, all 49 audits, block registry audit, and docs manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 25, 2026 7:24pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 12 files

Confidence score: 4/5

  • In apps/desktop/e2e/fixtures/browser-chrome.tsx, the mount effect, ResizeObserver/heartbeat, and cleanup may call reportPanelBounds when api.browserAgent is unavailable, causing runtime errors; guard these calls as well.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/desktop/e2e/fixtures/browser-chrome.tsx">

<violation number="1" location="apps/desktop/e2e/fixtures/browser-chrome.tsx:69">
P3: `startBrowser` guards `api.browserAgent` before use, but the mount effect, its ResizeObserver/1 s heartbeat, and the cleanup all call `reportPanelBounds(api, ...)` / `api.browserAgent.setPanelBounds` without any availability check. In any context where `window.simDesktop` is absent (plain-browser load of the fixture page, or a shell without the browser-agent bridge), the effect throws a TypeError on mount and white-screens the fixture instead of the guarded 'Native browser bridge is unavailable' message. Guard once at the top of the effect.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/emcn/src/components/toast/toast.tsx
Comment thread apps/desktop/e2e/fixtures/browser-chrome.tsx
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adjusts browser panel overlay handling and tab layout logic.

The PR appears safe to merge; no new actionable issue or outstanding previous finding remains.

Summary

The PR makes crowded floating tabs shrink before scrolling and keeps menus and tooltips above the native browser using snapshots. It adds real-Electron regression coverage. Since the previous review, it removes mocked-call assertions in favor of that coverage.

Reviews (3) · Last reviewed commit: "chore(tests): keep native refresh covera..."

Comment thread packages/emcn/src/components/tab-strip/tab-strip.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread apps/desktop/src/main/browser-agent/panel.test.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 9a21fbb into staging Sep 25, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/compact-tabs-native-overlays branch September 25, 2026 19:55

This branch was previously deployed

1 inactive deployment
Preview — 4969510a Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant