Skip to content

feat(extension): improve page capture, attachments, and browser shortcuts - #9629

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/opt-in-sim-new-tab
Nov 4, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/opt-in-sim-new-tab

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add a remembered, opt-in Reference current page on send setting. Keep page controls visible above long workspace lists, preserve drafts when access is missing, and let explicit page or selection attachments take priority.
  • Improve site-specific permission recovery, chip contrast and narrow-panel layout, and screenshot file drops across workspace, organization, and Assistant chats. Existing 0.1.2 shells remain compatible.
  • Show the actual keyboard binding and focus guidance, protect sensitive selections, and open sanitized, length-bounded Sim Link drafts from the browser context menu. Only Create saves a draft.
  • Add Browser shortcuts onboarding and optional recovery of explicit sim/name searches on supported search providers. Chrome applies declarative rules after site consent; ordinary searches and the default engine remain unchanged. Installation permissions are unchanged.
  • Add admin-only, organization-scoped managed bookmark export with current role, visibility, and link-identity checks. Preserve URL and description search matches. Document installation, shortcuts, permissions, and privacy.

Type of Change

  • Bug fix
  • Feature

Testing

  • Passed locally: lint, workspace type checks, audits, generators, block-registry validation, and adjacent tests. Full root tests and all canonical browser suites are required in CI before merge.
  • Passed locally: 32 packaged Chromium checks, 9 navigation checks, and 15 composer checks with one optional live-provider skip. CI passed all 39 hosted checks and 17 Sim Links HTTP checks on the final head.
  • Native Chrome permission deny/allow/revoke, browser restart, shortcut remapping and unassigned keys, protected selections, and narrow-panel interaction checks. Dia page capture, chip preview/removal, and single-attachment scrolling were also verified.
  • Regression controls were removed independently to demonstrate failures. The workspace-picker outage case uses deterministic ordering and real native window dimensions so bottom-row clicks exercise the hosted app.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Final CI tests passing (updated tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 3, 2026 19:06
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 4, 2026 2:35am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no new actionable issues were established.

Summary

This PR improves page capture and attachments in the Chrome sidebar and adds browser shortcut setup.

  • Sim Chat can add the active page when you send a message.
  • Explicit sim/name searches can open Sim Links from supported search sites.
  • Web links can become organization-bound Sim Link drafts and bookmarks.
  • Chat composers accept dropped screenshot files without treating links as uploads.
  • Extension guides and build metadata describe the new browser workflows.

No new actionable issues were established. waleedlatif1 explained that users can belong to only one organization and that rejecting outsiders is intentional. The earlier team-bookmark finding was withdrawn; the shared guard remains.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Send[User sends a message] --> Attached{Page already attached?}
  Attached -->|Yes| Commit[Send with attached snapshots]
  Attached -->|No| Enabled{Reference current page enabled?}
  Enabled -->|No| Plain[Send without a page]
  Enabled -->|Yes| Capture[Read the active page]
  Capture --> Valid{Access and page identity still valid?}
  Valid -->|No| Preserve[Keep the draft unsent]
  Valid -->|Yes| Unchanged{Draft and files unchanged?}
  Unchanged -->|No| Preserve
  Unchanged -->|Yes| Fresh[Send with the fresh snapshot]
Loading

Reviews (5) · Last reviewed commit: "fix(extension): bound link drafts and st..." · Reviewed by Greptile

Comment thread apps/extension/new-tab/new-tab.html Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 31 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/extension/new-tab/new-tab.html Resolved
@waleedlatif1 waleedlatif1 changed the title feat(extension): add an opt-in Sim new tab and fix faded attachments feat(extension): add opt-in new tabs and improve sidebar capture and shortcuts Nov 3, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 61 files

Confidence score: 4/5

  • In use-file-drop.ts, the editable-target exception can let a dragged web image through when its payload also includes text/plain, allowing native drop handling to fetch the remote resource. Narrow the exception so these image drops are handled by the app.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-file-drop.ts">

<violation number="1" location="apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-file-drop.ts:28">
P2: This exception is too broad for editable targets: a dragged web image can include `text/plain` alongside `text/html` or `text/uri-list`, so this return allows the browser’s native drop handling and can fetch the remote image. Exempt only genuinely plain-text drags by requiring neither `text/html` nor `text/uri-list` before returning.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/extension/scripts/test-e2e.ts Resolved
@waleedlatif1
waleedlatif1 force-pushed the codex/opt-in-sim-new-tab branch from 6042f8f to 8b05d67 Compare November 4, 2026 00:11
@waleedlatif1 waleedlatif1 changed the title feat(extension): add opt-in new tabs and improve sidebar capture and shortcuts feat(extension): improve page capture, attachments, and browser shortcuts Nov 4, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 61 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/extension/scripts/test-e2e.ts Resolved
Comment thread apps/extension/src/sidepanel.tsx Resolved
@waleedlatif1
waleedlatif1 force-pushed the codex/opt-in-sim-new-tab branch from 8b05d67 to 4c689a7 Compare November 4, 2026 01:21
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 65 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/extension/src/search-recovery.ts Resolved
Comment thread apps/sim/app/sim-links/recover/route.ts Resolved
Comment thread apps/extension/src/sidepanel.tsx Resolved
@waleedlatif1
waleedlatif1 force-pushed the codex/opt-in-sim-new-tab branch from 4c689a7 to 2b1d31a Compare November 4, 2026 02:31
@waleedlatif1

ghost commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

ghost commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

ghost commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

ghost left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 65 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/extension/scripts/test-e2e.ts Resolved

This branch was successfully deployed

1 active deployment
Preview — 2b1d31aa Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant