Skip to content

improvement(ci): avoid unrelated asset checks and browser downloads - #9641

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/ci-asset-attribution
Nov 3, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/ci-asset-attribution

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep library media changes on the production-build and SEO path without unrelated integration, browser, desktop, or docs suites.
  • Fetch only the checked revision for docs acceptance; retain full history for attribution and generated dates.
  • Download only the Chromium runtime each browser suite launches.

Type of Change

  • Improvement

Testing

Full root test suite on Linux: 42,661 passed, 11 existing skips; all 20 workspace tasks passed uncached. Lint, type-check (29 workspaces), 62 audits, block registry, actionlint, ShellCheck, and Bash syntax passed. Real Git/Turbo attribution covers media additions, deletions, renames, and conservative unknown-asset routing; both routing guards were independently demonstrated red. Browser and generated-date compatibility validated at the actual runtime boundary.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 3, 2026 10:18pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

This PR trims CI work without removing the checks that own library media.

  • Library media changes select the SEO checks without shared runtime checks.
  • Browser suites download only the Chromium mode they use.
  • Docs acceptance checks use a shallow checkout.

Reviews (1) · Last reviewed commit: "improvement(ci): keep library media on t..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 3227822 into staging Nov 3, 2026
69 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-asset-attribution branch November 3, 2026 22:19
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Validation completed for the reviewed commit.

  • Full Linux root gate: 42,661 passed, 11 existing skips; all 20 workspace tasks passed uncached. Lint, 29 workspace type checks, 62 audits, workflow lint, and shell checks passed.
  • All hosted PR checks passed. All 279 baseline browser cases are retained, with one additional upstream organization-search case; all 3,333 docs cases retain their statuses and screenshot inventories.
  • Both reviewers report 5/5 with zero open review threads. The squash tree matches the reviewed change applied to its actual staging parent.
  • Runtime logs verify shallow docs acceptance checkouts and removal of the unused Chromium download. OS package download variability still dominates some browser setup times.

This branch was successfully deployed

1 active deployment
Preview — cd0647fc Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant