Skip to content

fix(desktop): download Bun fresh in the signed release build - #9703

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/desktop-build-bun-no-cache
Nov 5, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/desktop-build-bun-no-cache

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Signed build job now gets its own setup-bun step with no-cache: true, because the action caches the Bun binary by default and that binary runs the install and build for what gets signed
  • Completes fix(desktop): keep signed release builds off shared caches #9701, whose "restores no caches" guarantee missed this implicit cache

Type of Change

  • Bug fix

Testing

  • actionlint on the workflow
  • Unsigned dispatch from a temporary tag; the build job log is checked for cache restores, with the result in a comment below

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 5, 2026 3:51am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This change appears safe to merge; no actionable issues were found.

Summary

The desktop build job now configures Bun separately with no-cache: true.

  • The signed release build downloads Bun without using its cache.

Reviews (1) · Last reviewed commit: "fix(desktop): download Bun fresh in the ..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit e5cdbcf into staging Nov 5, 2026
60 of 61 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/desktop-build-bun-no-cache branch November 5, 2026 03:42
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Dispatch passed, unsigned and unpublished, from a temporary tag that has since been deleted. The build job log shows no-cache: true, zero cache restores, and fresh Bun and Electron downloads. It ran on ded6d69b69; the only later commit removes the unused YAML anchor.

This branch was successfully deployed

1 active deployment
Preview — eeeab589 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant