Skip to content

fix(search): preserve query attribution on fused results - #9730

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/search-discovery-audit
Nov 6, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/search-discovery-audit

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve original native-query indexes on fused Search results so callers can attribute a document to the searches or folders that returned it.
  • Keep the optional metadata in the Search MCP response and generated Assistant contract. Ranking, permissions, pagination and provider requests are unchanged.

Type of Change

  • Bug fix

Testing

  • Regression assertions failed before each production fix and pass afterward.
  • 38 real MCP/DB integration checks and 100 focused application/MCP tests pass.
  • Root lint, type-check, all 63 audits, test-type ratchet and full test suite pass.
  • Model evaluation and harness corrections are tracked in the companion worker PR. The final evaluation retains one model input/retry failure; no zero-error model claim.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Companion: simstudioai/mothership#930

@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 6, 2026 4:46am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Preserves the original native-query indexes on fused live-search results.

  • Fused Search results show which native queries found each document.

No actionable issues found. Tests were inspected, not run.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A["nativeQueries with original indexes"] --> B["Search each matching account"]
  B --> C["Fuse results and retain matched search positions"]
  C --> D["Read original queryIndex from each matched search"]
  D --> E["Remove repeats and sort queryIndexes"]
  E --> F["Assistant and MCP responses"]
Loading

Reviews (1) · Last reviewed commit: "fix(search): preserve query attribution ..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit eb4eb57 into staging Nov 6, 2026
62 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-discovery-audit branch November 6, 2026 04:50
@github-actions github-actions Bot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

⚠️ Cross-repo companion check

One or more companion PRs aren't merged into staging yet. Merging this without them will leave copilot and sim out of sync — merge them in lockstep.

  • ❌ simstudioai/mothership#930 — OPEN, not merged (targets staging) — fix(search): preserve query attribution in discovery evaluation

This branch was previously deployed

1 inactive deployment
Preview — 141ebf03 Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant