Skip to content

[Warrior] Handle rend_dot for blizz apl #11984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Armadk merged 1 commit into from
Oct 28, 2026
Merged

[Warrior] Handle rend_dot for blizz apl #11984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions engine/class_modules/sc_warrior.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,7 @@ struct warrior_t : public parse_player_effects_t
void parse_assisted_combat_step( const assisted_combat_step_data_t& step, action_priority_list_t* assisted_combat ) override;
parsed_assisted_combat_rule_t parse_assisted_combat_rule( const assisted_combat_rule_data_t& rule, const assisted_combat_step_data_t& step ) const override;
std::vector<std::string> action_names_from_spell_id( unsigned int spell_id ) const override;
std::string aura_expr_from_spell_id( unsigned int spell_id, bool on_self ) const override;

action_t* create_action( util::string_view name, util::string_view options ) override;
void activate() override;
Expand Down Expand Up @@ -8964,6 +8965,16 @@ std::vector<std::string> warrior_t::action_names_from_spell_id( unsigned int spe
return player_t::action_names_from_spell_id( spell_id );
}

// warrior_t::aura_expr_from_spell_id ======================================
std::string warrior_t::aura_expr_from_spell_id( unsigned int spell_id, bool on_self ) const
{
// Blizz apl references the Rend bleed aura, but the simc dot action is named rend_dot
if ( !on_self && spell.rend_dot->id() == spell_id )
return "dot.rend_dot";

return player_t::aura_expr_from_spell_id( spell_id, on_self );
}

// warrior_t::arise() ======================================================

void warrior_t::arise()
Expand Down
Loading