Added handling of case where shell cannot be found in add_process - #998
Open
kzscisoft wants to merge 1 commit into
Open
Added handling of case where shell cannot be found in add_process#998kzscisoft wants to merge 1 commit into
kzscisoft wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Shell not found for
add_processIssue: #997
Python Version(s) Tested: 3.14
Operating System(s): Ubuntu 26.04
📝 Summary
Fixes an issue where
get_current_shellreturnsNoneand thereforeNoneis used in a string check.🔍 Diagnosis
Execution of code on Apptainer via HPC systems leads to no shell being identified.
🔄 Changes
Modified comparison to
if any(shell in (get_current_shell() or "") for shell in ('pwsh', 'powershell')):.✔️ Checklist