fix(schema): add missing background-attribution GSettings keys - #251
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Holding because its schema and submodule bumps only support the unaccepted wallpaper-provider branch in singularity-shell#26. |
e519bcd to
b75faa4
Compare
|
Merged the others, need fix here for the conflicts |
singularity-shell master reads show-wallpaper-attribution unguarded in desktop_page.vala and background.vala, and background-attribution-title and -author through SettingsSafety. g_settings_get_boolean() on a key the schema does not declare aborts the process, so opening the Desktop settings page crashes until these keys exist. Rebased onto current master and reduced to the schema alone. The singularity-shell submodule bump is dropped: master already points at a newer commit than this branch carried, so it was a regression as well as an unrelated concern. Assisted-by: Claude Code:claude-opus-5 AI-Scope: Rebased the branch onto master, dropped the submodule-bump commit, and tightened the key descriptions.
b75faa4 to
1a0d96e
Compare
|
Conflicts fixed and the hold reason has resolved itself. Head is The hold. You held this because the keys only supported the then-unaccepted provider work in singularity-shell#26. #25, #26 and #27 have since merged, so those readers are on
Conflicts. The conflict was the Verification. @mirkobrombin no open review object to dismiss here, just the hold comment - flagging that its reason no longer applies. Ready for a look. |
Summary
singularity-shellmaster reads three keys this schema does not declare:show-wallpaper-attribution- read unguarded viasettings.get_boolean()indesktop_page.vala:317andbackground.vala:283background-attribution-title/background-attribution-author- writtenthrough
SettingsSafetyfromdesktop_page.vala,desktop_icons.valaandwallpaper_manager.valag_settings_get_boolean()on a key the schema does not declare is a fatalerror, not a catchable one, so opening the Desktop settings page aborts the
process until these keys exist.
Changes since the earlier hold
The hold reason was that these keys only supported the then-unaccepted
wallpaper provider work in singularity-shell#26. #25, #26 and #27 have since
merged, so the readers listed above are on
maintoday -git grepfor eachkey name finds them.
Rebased onto current
masterand reduced to the schema alone. Thesingularity-shellsubmodule bump is dropped:masteralready points at4945d4d, newer than thec10ad57this branch carried, so the bump was aregression as well as an unrelated concern.
Test plan
glib-compile-schemasaccepts the filegsettings get dev.sinty.desktopreturnstrue,''and''for the three new keysgit grepon singularity-shellmainconfirms a real reader for eachAI assistance: disclosed