Conversation
perlowja
force-pushed
the
feat/wallpaper-attribution-quadrant-schema
branch
from
September 18, 2026 20:13
8c033f7 to
d0447a7
Compare
perlowja
added a commit
to perlowja/singularity-shell
that referenced
this pull request
Sep 18, 2026
Extends the wallpaper title/author overlay from a fixed bottom-left position to a user-selected quadrant (top-left, top-right, bottom-left, bottom-right), exposed as a Settings row below the existing visibility toggle. An invalid or unset value safely falls back to bottom-left, matching the previous fixed behavior. The contrast-sampling rect (corner_luminance_frac call in update_attribution()) now tracks the active quadrant too -- it previously always sampled the bottom-left corner of the wallpaper regardless of where the label actually sat, which would have picked light/dark text against the wrong part of the image for any non-bottom-left placement. Needs the wallpaper-attribution-position schema key (singularityos-lab/singularity-desktop#262). This ports and extends a working left/right-only version the operator had running locally (never previously upstreamed) to the full 4-quadrant case the current design calls for. Assisted-by: Claude Code:claude-sonnet-5 AI scope: extended halign/valign switch to 4 quadrants, fixed the contrast-sample rect to track the active quadrant, added the Settings picker row. Assisted-by: Claude Code:claude-sonnet-5 AI-Scope: Ported and extended prior left/right attribution-position vala logic to full 4-quadrant support, plus fixed the contrast-sample rect to track the active quadrant.
Adds the string key the shell wallpaper overlay needs to remember which screen quadrant the title/author caption anchors to (top-left, top-right, bottom-left, bottom-right), independent of show-wallpaper-attribution. Defaults to bottom-left, matching the overlay current fixed position, so this is additive and changes no existing default behavior on its own. Companion PR against singularity-shell reads this key and adds the quadrant picker UI. Assisted-by: Claude Code:claude-sonnet-5 AI-Scope: Extended the wallpaper-attribution-position schema key from left/right to 4 quadrants (top-left/top-right/bottom-left/bottom-right), ported from prior NCZ implementation.
perlowja
force-pushed
the
feat/wallpaper-attribution-quadrant-schema
branch
from
September 18, 2026 20:14
d0447a7 to
f7c5d3b
Compare
perlowja
added a commit
to perlowja/singularity-shell
that referenced
this pull request
Sep 18, 2026
Extends the wallpaper title/author overlay from a fixed bottom-left position to a user-selected quadrant (top-left, top-right, bottom-left, bottom-right), exposed as a Settings row below the existing visibility toggle. An invalid or unset value safely falls back to bottom-left, matching the previous fixed behavior. The contrast-sampling rect (corner_luminance_frac call in update_attribution()) now tracks the active quadrant too -- it previously always sampled the bottom-left corner of the wallpaper regardless of where the label actually sat, which would have picked light/dark text against the wrong part of the image for any non-bottom-left placement. Needs the wallpaper-attribution-position schema key (singularityos-lab/singularity-desktop#262). This ports and extends a working left/right-only version the operator had running locally (never previously upstreamed) to the full 4-quadrant case the current design calls for. contrast-sample rect to track the active quadrant, added the Settings picker row. Assisted-by: Claude Code:claude-sonnet-5 AI-Scope: Ported and extended prior left/right attribution-position vala logic to full 4-quadrant support, plus fixed the contrast-sample rect to track the active quadrant.
Contributor
Author
|
@mirkobrombin bumping this - the schema companion #30 on singularity-shell needs. |
Member
|
Fine, will merge together with singularity-shell#30 once that one is fixed. The commit's AI-Scope talks about extending left/right to 4 quadrants, which doesn't match this repo, please fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the string key
wallpaper-attribution-position("top-left"/"top-right"/"bottom-left"/"bottom-right", defaultbottom-left) alongside the existingshow-wallpaper-attributionboolean.This is purely additive — the default matches the overlay's current fixed bottom-left position, so nothing changes for anyone until the shell side (companion PR against singularity-shell, to follow) reads it.
Verified:
xmllint --nooutandglib-compile-schemasboth pass clean on the changed file.Assisted-by: Claude Code:claude-sonnet-5
AI scope: added the schema key and its description.
AI assistance: disclosed