fix: add guard to avoid packet sent on shutdown on already dead streams - #2147
Closed
bundasmanu wants to merge 2 commits into
Closed
fix: add guard to avoid packet sent on shutdown on already dead streams#2147bundasmanu wants to merge 2 commits into
bundasmanu wants to merge 2 commits into
Conversation
rfuchs
reviewed
Jul 27, 2026
| struct stream_fd *sfd = d->sfd; | ||
| if (!sfd) | ||
| return ret; | ||
| if (!sfd->socket.family || sfd->socket.fd < 0) |
Member
There was a problem hiding this comment.
Suggest to change the test for open socket to != -1
Technically I think the test on fd can be removed altogether, as (in theory) we guarantee the socket to be open if family is set
Contributor
Author
There was a problem hiding this comment.
So, if i understood, you mean to do a simple check like this? if (!sfd->socket.family)
Contributor
Author
There was a problem hiding this comment.
I will test, and after i will you give feedback. Thank you.
EDIT: Worked, thank you.
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 27, 2026
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 27, 2026
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 27, 2026
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue: 2146.
The fix results from gdb analysis, and uses a similar approach that was used previously on similar problems like: (linuxmaniac@ceb7996).
I already have tested it, and crashes are not happening anymore.