Update/phpunit unit tests - #119
Merged
Merged
Conversation
rhendrickson-sc
left a comment
rhendrickson-sc
left a comment
There was a problem hiding this comment.
Overall looks solid! Just left some questions for ya.
…nto require, bumping phpunit to 12.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No format to follow here!
A lot of this is based on what was done for the Conifer unit tests. This only includes unit tests, there is no integration tests (coming soon!)
I've also included a workflow for running the tests on PR, lando tooling for running the tests, and starter unit tests. Also, it did not make sense to include it now, so I did not include a copilot prompt for generating unit tests.