Repository navigation
Fail closed after an interrupted async exchange - #37
Open
chenty2333 wants to merge 1 commit into
Open
chenty2333 wants to merge 1 commit into
chenty2333 wants to merge 1 commit into
Conversation
A cancelled query or pipeline can leave an unread reply on the connection. Reusing it associates that reply with the next request, including when checkout validation consumes the stale reply first. Poison incomplete exchanges and reject later operations without writing. Have both async pool managers discard poisoned connections, and document that direct users must reconnect. Complete responses, including server errors, remain reusable. Add regression coverage for cancellation, partial reads/writes, EOF, protocol errors, unpolled futures and completed replies. Assisted-by: LLM Signed-off-by: Tianyi Chen <hi@tychen.cc>
Author
|
I'm happy to sign the CLA, but the signing page reports 'Bad credentials' and says there is no CLA to sign. Could you please check the CLA service configuration? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cancelled query or pipeline can leave its reply unread. Reusing the connection then returns that reply to the next request. Pool checkout validation can consume a stale reply too, so validation alone does not prevent the mismatch.
Track incomplete exchanges with a drop guard. Later operations return
ConnectionAbortedwithout writing, and both TCP and TLS pool managers discard the poisoned connection. Direct users must reconnect. Complete replies, including server errors, remain reusable; dropping an unpolled future does not poison the connection. No public API is added.The patch does not undo or replay the cancelled request: it may already have executed on the server.
Validation:
cargo check --all-targets, formatting and diff checks pass.