Skip to content

feat: add webapi response changes as of 2026-08-22 - #1636

Open
slackapi[bot] wants to merge 6 commits into
mainfrom
api
Open

feat: add webapi response changes as of 2026-08-22#1636
slackapi[bot] wants to merge 6 commits into
mainfrom
api

Conversation

@slackapi

@slackapi slackapi Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

This PR updates the web API client and model based on the production E2E test results.

Category

  • slack-api-model (Slack API Data Models)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@slackapi
slackapi Bot requested a review from a team as a code owner August 22, 2026 00:54
@slackapi slackapi Bot added project:slack-api-model project:slack-api-model semver:patch labels Aug 22, 2026
@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (b7562e3) to head (6b04b0d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1636   +/-   ##
=========================================
  Coverage     72.87%   72.87%           
  Complexity     4522     4522           
=========================================
  Files           479      479           
  Lines         14390    14390           
  Branches       1503     1503           
=========================================
  Hits          10487    10487           
  Misses         3013     3013           
  Partials        890      890           
Flag Coverage Δ
jdk-14 72.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

zimeg and others added 5 commits August 24, 2026 13:51
Detected by the runner's audit-log test (getActions_detectingNewOnes)
as an unknown App action returned by the live audit API.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
The live audit API returns this action under getUser(), not getApp()
(confirmed by a local task test:audit run). a205d62 declared it in
Actions.App, so getActions_detectingNewOnes still failed on the User
loop. Move it to the correct bucket.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
The sample-JSON masker blanks the Lists item `message` field to `[""]`
because the live value is often empty, which makes downstream type
generation infer `string[]` instead of the message-object shape the API
actually returns. Add a path-gated (`/api/slackLists.`) branch that
injects a populated Message, so the sample reflects the real object shape.

Fixes the sample side of slackapi/node-slack-sdk#2598 (wrong TS response
type). Separate from java-slack-sdk#1587, the already-fixed runtime
deserialization crash.

❤️
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant