fix(socket_mode): check the effective log level in debug guards - #1965
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
The debug guards compared logger.level, which is NOTSET unless a level is set on that exact logger, so the guarded messages were built even when DEBUG is disabled through a parent logger. Use isEnabledFor(), which follows the effective level. Refs slackapi#1957 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Socket Mode part of #1957.
The debug guards compared
logger.level, which staysNOTSETunless a level is set on that exact logger, so the guarded messages (includingdebug_redacted_message_string(message)for every inbound message) were built even when DEBUG was disabled through a parent logger. They now useisEnabledFor(logging.DEBUG), which follows the effective level.I kept this to
slack_sdk/socket_mode/; the same pattern in the other modules can follow separately if you want it project-wide.The added test checks that the message is not built when a parent logger is at INFO and is built at DEBUG; it fails before this change. The Socket Mode test suites (sync and async), ruff and mypy pass.
🤖 Generated with Claude Code