Repository navigation
chore: the lexer's builder writes discard what cannot fail - #23
Merged
Merged
Conversation
golangci-lint's errcheck reported three unchecked strings.Builder writes in the single-quoted string literal loop. A strings.Builder's writes never return an error; the error is discarded on purpose, and the two quotes of an escaped quote are one write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
golangci-lint runreported threeerrcheckfindings infilter_lexer.go: thestrings.Builderwrites of the single-quoted string literal loop were unchecked.How
A
strings.Builder's writes never return an error, so the error is discarded on purpose (_, _ =), with a comment saying so; the two quotes an escaped quote is kept as are oneWriteString("''"). Nothing the lexer produces changes.Verified locally
golangci-lint run ./...: 0 issues (was 3).go vet ./...clean;go test -race -tags=unit ./...passes..testcoverage.yml): 97.5%, thresholds satisfied.🤖 Generated with Claude Code