Repository navigation
ci: a failing step fails the job - #24
Merged
Merged
Conversation
Every step runs with "shell: bash", which GitHub runs with pipefail. A step that names no shell runs as "bash -e" without it, so "go test ... | tee" and the coverage check piped through sed and tee took tee's status: a failing test or a coverage below its threshold passed the job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A failing step fails the job. The pull request and release workflows ran their steps with GitHub's default shell for a step that names none,
bash -e {0}, which has nopipefail. Two steps pipe their command intoteefor the step summary:go test -race ... ./... | tee -a $GITHUB_STEP_SUMMARYgo-test-coverage --config=./.testcoverage.yml | sed ... | sed ... | tee -a $GITHUB_STEP_SUMMARYA pipeline's status is its last command's,
tee's, so a failing test or a coverage below its threshold passed the job.How
defaults.run.shell: bashin both workflows. GitHub runs a step that namesbashasbash --noprofile --norc -eo pipefail {0}, so a pipeline fails when any of its commands does. Nothing else changes.Verified locally
bash -e -c 'false | tee /dev/null; echo ...'goes on and exits 0;bash --noprofile --norc -eo pipefail -c '...'exits 1 at the pipeline.actionlinton both workflows: nothing about this change.🤖 Generated with Claude Code