Repository navigation
ci: the summary reads the pull request through env - #25
Merged
christiangda merged 1 commit intoOct 18, 2026
Merged
Conversation
The summary step wrote the pull request's title, author and branches into its script as expressions. They reach it as environment variables now, as GitHub's hardening guide asks: what the author writes is data to the script, never part of it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
christiangda
deleted the
ci/the-summary-reads-the-pull-request-through-env
branch
October 18, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The pull request workflow's summary step wrote
${{ github.event.pull_request.title }}, the author's login and the two branch names into its script. An expression inrun:is substituted into the script's text before the shell reads it, so they were part of the script. They reach it as environment variables now, as GitHub's security hardening guide recommends.How
env:on the step (PR_TITLE,PR_AUTHOR,PR_HEAD,PR_BASE), and theecholines read${PR_TITLE}and the rest. The repository, the counts and the other values stay as they were: they are GitHub's, not the author's.Verified locally
actionlinton the workflows: clean (it reported the title in the script before).$(echo ran-a-command): as text in the script the shell runs the command; read from the environment it is printed as written.🤖 Generated with Claude Code