Repository navigation
fix: the PostgreSQL dialect names its version - #29
Merged
Merged
Conversation
DialectSQLStandard says SQL:2023 and DialectPostgreSQL said PostgreSQL: the grammar is PostgreSQL 18's, checked against PostgreSQL 18, and its name, the package doc, the guides and the documentation index's diagram now say so. Only a caller that compares String() changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DialectSQLStandard.String()isSQL:2023, andDialectPostgreSQL.String()was a barePostgreSQL. The grammar is PostgreSQL 18's, and every rule is checked against PostgreSQL 18, so each dialect now names its version.String()isPostgreSQL 18.configuration.mdandgetting-started.md;migration.md, which has a v1.1.0 → v1.1.1 note: only a caller that compares the string changes, and the grammar does not.This is v1.1.1:
v1.1.0is already tagged and public, so it is not moved.go test -racepasses, andgolangci-lintreports 0 issues.🤖 Generated with Claude Code