Skip to content

Fail step context list when there are no contexts #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

Fail step context list when there are no contexts #1693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion command/context/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package context
import (
"fmt"

"github.com/pkg/errors"
"github.com/urfave/cli"

"github.com/smallstep/cli-utils/command"
Expand Down Expand Up @@ -37,12 +38,20 @@ ssh.beta
func listAction(*cli.Context) error {
cs := step.Contexts()

contexts := cs.ListAlphabetical()
if len(contexts) == 0 {
// Printing nothing and exiting 0 is indistinguishable from a STEPPATH
// that has contexts but none of them listable, so say so and fail the
// way `step context current` does when there is nothing selected.
return errors.New("no contexts present")
}

cur := cs.GetCurrent()
if cur != nil {
fmt.Printf("▶ %s\n", cur.Name)
}

for _, v := range cs.ListAlphabetical() {
for _, v := range contexts {
if cur != nil && v.Name == cur.Name {
continue
}
Expand Down