Add support for ML-DSA algorithms - #1098
Open
maraino wants to merge 17 commits into
Open
Conversation
This commit adds support for creating keys and signing using ML-DSA-44, ML-DSA-65, and ML-DSA=87 algorithms on GCP cloud KMS.
This commit uses the key type (kty) AKP for ML-DSA keys matching RFC 9964, ML-DSA for JSON Object Signing and Encryption (JOSE) and CBOR Object Signing and Encryption (COSE) It also adds support for softkms.
maraino
force-pushed
the
mariano/pq-cloudkms
branch
from
August 12, 2026 18:47
7f08a54 to
da9db5c
Compare
maraino
force-pushed
the
mariano/pq-cloudkms
branch
from
August 12, 2026 19:38
da9db5c to
c418c78
Compare
For some reason Go 1.27 gets an error when downloading the Cavium root certificate. Changing the user agent fixes the issue.
maraino
changed the title
This change makes the mldsa public, but only temporary to add simpler support on packages like smallstep/cli and smallstep/certificates.
maraino
force-pushed
the
mariano/pq-cloudkms
branch
from
August 31, 2026 21:40
d3f8b38 to
d6c1152
Compare
maraino
marked this pull request as ready for review
August 31, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for creating keys and signing using ML-DSA-44, ML-DSA-65, and ML-DSA-87 algorithms on GCP cloud KMS, AWS KMS, softkms, and keyutil and pemutil packages.
It also upgrades Go to 1.26+, uses
go fixto modernize Go, and changes the deprecated fields in ECDSA keys to use mainly theecdsa.PublicKey.Bytes(),ecdsa.PrivateKey.Bytes()andecdsa.ParseUncompressedPublicKey()methods.We could use smallstep/step-kms-plugin#364 to test other implementations.