Add vault don settings - #2357
Open
russell-stern wants to merge 4 commits into
Open
Conversation
Contributor
|
👋 russell-stern, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
✅ API Diff Results -
|
jmank88
reviewed
Sep 4, 2026
Comment on lines
+142
to
+148
| uint64 max_identifier_key_length_bytes = 1; | ||
| uint64 max_identifier_owner_length_bytes = 2; | ||
| uint64 max_identifier_namespace_length_bytes = 3; | ||
| uint64 max_share_length_bytes = 4; | ||
| uint64 max_blob_payload_bytes = 5; | ||
| uint64 max_pending_queue_write_size = 6; | ||
| uint64 max_request_batch_size = 7; |
Contributor
There was a problem hiding this comment.
nit/ sometimes moving qualifiers like max towards the end of names makes things sort/group more naturally.
On the other hand, is this always just a collections of limits/maxes? If so, could we drop the qualifier from each field by communicating it another way? Might be confusing though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.