Repository navigation
Standardize verification and test targets - #878
Merged
Merged
Conversation
kuhe
force-pushed
the
kuhe/chore/verification
branch
3 times, most recently
from
October 30, 2026 17:22
046087a to
e4f806b
Compare
kuhe
changed the title
kuhe
changed the title
kuhe
marked this pull request as ready for review
October 30, 2026 17:33
kuhe
force-pushed
the
kuhe/chore/verification
branch
from
October 30, 2026 17:33
e4f806b to
085752d
Compare
stobrien89
approved these changes
Oct 30, 2026
stobrien89
approved these changes
Oct 30, 2026
jonathan343
reviewed
Oct 30, 2026
|
|
||
|
|
||
| test-unit: ## Runs the python unit tests. | ||
| uv run pytest packages/*/tests/unit |
Contributor
There was a problem hiding this comment.
With a command like this, we saw issues in the past where test files with the same names in different packages would cause some tests not to get run. Related PR: #521
Can you investigate to see if this is still an issue or now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paired with aws/aws-sdk-python#119
This PR adds the following phony but canonical make targets, standardizing development, CI, and release build verifications.
make static-analysisThis includes what isn't technically static in the traditional sense like
loading a module and using reflection to analyze it, but generally covers analysis
of the code without running the code's function bodies.
This covers things like API surface symbol analysis, aio partitioning and naming, and future not-yet-developed correctness analyses.
Included are 3rd party verifications like pyright and ruff.
make test-unitTests which exercise a small number of code units, mocking dependencies. Fast tests.
make test-functionalTests of mainly the public API but without making real HTTP requests.
Typically these would be HTTP mocks, HTTP snapshot tests,
or multi-unit tests. Some crossover with the concept of an integration test, but consider these the medium-speed tests.
make test-integrationTests against live services, or complex end to end tests like the codegen-output snapshot path. Slowest set of tests.