Skip to content

SNOW-2912540: add IS_V5_DRIVER constant for version-conditioned connector imports - #4310

Closed
sfc-gh-fpawlowski wants to merge 2 commits into
SNOW-2912540-decouple-oob-telemetryfrom
SNOW-2912540-is-v5-driver-constant
Closed

SNOW-2912540: add IS_V5_DRIVER constant for version-conditioned connector imports#4310
sfc-gh-fpawlowski wants to merge 2 commits into
SNOW-2912540-decouple-oob-telemetryfrom
SNOW-2912540-is-v5-driver-constant

Conversation

@sfc-gh-fpawlowski

@sfc-gh-fpawlowski sfc-gh-fpawlowski commented Aug 6, 2026

Copy link
Copy Markdown

Removes two imports from snowflake-connector-python that the Universal Driver connector no longer provides as shims.

  • `async_job.py`: `ASYNC_RETRY_PATTERN` defined locally (was imported from `connector.cursor`)
  • `mock/_telemetry.py`: `from http.client import OK` (was imported from `connector.compat`)

Companion changes in snowflake-eng/universal-driver PR #512 and #513.


Stack (via Graphite)

🤖 Generated with Claude Code

…ctor imports

connector_version is already imported in utils.py; this one-liner exposes a
boolean flag so callers can gate imports or behavior that differs between the
legacy connector (v3/v4) and the Universal Driver (v5+).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

sfc-gh-fpawlowski commented Aug 6, 2026

Copy link
Copy Markdown
Author

@sfc-gh-fpawlowski
sfc-gh-fpawlowski marked this pull request as ready for review August 17, 2026 18:00
@sfc-gh-fpawlowski
sfc-gh-fpawlowski requested a review from a team as a code owner August 17, 2026 18:00
@sfc-gh-fpawlowski
sfc-gh-fpawlowski requested review from sfc-gh-aling, sfc-gh-bkogan and sfc-gh-jzeng and removed request for a team August 17, 2026 18:00

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed

This PR was classified as LOW risk by the automated pre-screen.

@sfc-gh-fpawlowski

Copy link
Copy Markdown
Author

Folded into #4313 — this PR's single commit (add IS_V5_DRIVER constant) already lives in #4313's branch history, so #4313 has been retargeted to base directly on #4309 and its description updated to cover both changes.

1 similar comment
@sfc-gh-fpawlowski

Copy link
Copy Markdown
Author

Folded into #4313 — this PR's single commit (add IS_V5_DRIVER constant) already lives in #4313's branch history, so #4313 has been retargeted to base directly on #4309 and its description updated to cover both changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant