Skip to content

test(ci): stop failing fast#677

Open
rrama wants to merge 1 commit into
mainfrom
test/ci-stop-failing-fast
Open

test(ci): stop failing fast#677
rrama wants to merge 1 commit into
mainfrom
test/ci-stop-failing-fast

Conversation

@rrama

@rrama rrama commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Description

Keep running all tests even if one OS fails.

Checklist

Screenshots / GIFs

N/A

Keep running all tests even if one OS fails.
@snyk-io

snyk-io Bot commented Nov 5, 2025

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@rrama rrama marked this pull request as ready for review November 5, 2025 18:01
@rrama rrama requested review from a team as code owners November 5, 2025 18:01

@bastiandoetsch bastiandoetsch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single-line CI matrix toggle: fail-fast: false is correctly placed under strategy (sibling of matrix), so all three OS jobs (ubuntu/macos/windows) run to completion instead of being cancelled when one fails — exactly the intent, and useful for seeing cross-platform failures together. No build/test logic affected. Correct.

— AI review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants