refactor: changes for the wpt convolver and delay by mdydek · Pull Request #1308 · software-mansion/react-native-audio-api

mdydek · 2026-09-24T11:19:37Z

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

swap the writer and delay in the delaynode so it works correctly
constantsourcenode and oscillatornode emit mono output per spec
properly validate options in convolver and delay
do not zero nyquist component, but treat it separately as two real numbers instead of one complex, because our fft implementation treat those values this way
do not treat channelCount property in the audio node as number of channels being given to the output

Checklist

Linked relevant issue
Updated relevant documentation
Added/Conducted relevant tests
Performed self-review of the code
Updated Web Audio API coverage
Added support for web
Updated old arch android spec file

github-actions · 2026-09-24T11:25:18Z

WPT non-regression comparison

FAIL — 1 regressed section(s), 3 file(s) with new failing subtests · 5 improved section(s) · overall 3420 → 3427 (+7)

Spec section	Base pass	Head pass	Delta
ConvolverNode	203	178	-25
Processing model	0	1	+1
AudioBufferSourceNode	218	220	+2
DelayNode	104	127	+23
PannerNode	723	727	+4
StereoPannerNode	102	104	+2

New failing subtests:

the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html
- X 3: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 3: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 4: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 4: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 5.1: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}.
  Index Actual Expected A
- X 5.1: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}.
  Index Actual Expected A
the-audio-api/the-convolvernode-interface/convolver-response-2-chan.html
- X 1: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 2: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 3: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 3: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 4: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 4: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expected AbsError
- X 5.1: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}.
  Index Actual Expected A
- X 5.1: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}.
  Index Actual Expected A
- X 2-in explicit mode: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual E
- X 3-in explicit: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expect
- X 4-in explicit: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
  Index Actual Expect
- X 5.1-in explicit: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0.0000016280238925805544,"relativeThreshold":0}.
  Index Actual
the-audio-api/the-convolvernode-interface/convolver-response-4-chan.html
- X 1: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}.
  Index Actual Expected AbsErro
- X 3: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}.
  Index Actual Expected AbsErro
- X 3: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}.
  Index Actual Expected AbsErro
- X 4: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}.
  Index Actual Expected AbsErro
- X 4: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}.
  Index Actual Expected AbsErro
- X 5.1: Channel 0 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0.0000017267801015661442,"relativeThreshold":0}.
  Index Actual Expected A
- X 5.1: Channel 1 does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0.0000017267801015661442,"relativeThreshold":0}.
  Index Actual Expected A

Unchanged sections (22)

Spec section	Base pass	Head pass
Other	56	56
AnalyserNode	138	138
AudioBuffer	140	140
AudioContext	58	58
AudioNode	261	261
AudioParam	680	680
BiquadFilterNode	275	275
ChannelMergerNode	30	30
ChannelSplitterNode	7	7
ConstantSourceNode	64	64
DestinationNode	0	0
DynamicsCompressorNode	4	4
GainNode	15	15
IIRFilterNode	87	87
MediaElementAudioSourceNode	0	0
MediaStreamAudioDestinationNode	1	1
MediaStreamAudioSourceNode	0	0
OfflineAudioContext	35	35
OscillatorNode	104	104
PeriodicWave	33	33
ScriptProcessorNode	0	0
WaveShaperNode	82	82

_{Baseline: 87cca81bff30ee15f3a407008cdc2ee30527ef89 · Candidate: 524d440ebe9ed4f6b479798ba52be7bbab99c75a}

_{Workflow run · this comment is updated on every push.}

closetcaiman · 2026-09-25T17:35:40Z

  [[nodiscard]] size_t getChannelCount() const;

+  /// @brief Returns how many channels this node emits on its output.
+  [[nodiscard]] size_t getOutputChannelNumber() const;


Is there a specific reason for this to be named *Number instead of *Count?

to me *Number seems like getting a specific channel

because the ChannelCount refers to something else totally in the api and it would be very chaotic if it was named like that.

closetcaiman · 2026-09-25T18:21:39Z

-    return negotiatedChannelCount;
+    return numberOfInputs_ == 0 ? getOutputChannelNumber() : negotiatedChannelCount;
  }



Can't overrides of this method solve the problem of outputChannelCount?

mdydek added the refactor Code restructuring without altering external behavior or fixing bugs label Sep 24, 2026

mdydek added this pull request to stack #1310 September 24, 2026 11:37

mdydek force-pushed the refactor/delay-convolver-wpt-improvements branch from 70209cd to e954a4c Compare September 24, 2026 13:20

refactor: changes for the wpt convolver and delay

20f7019

mdydek force-pushed the refactor/delay-convolver-wpt-improvements branch from e954a4c to 20f7019 Compare September 24, 2026 14:37

closetcaiman approved these changes Sep 24, 2026

View reviewed changes

refactor: do not treat channel count as number of output channels

7902939

mdydek requested a review from closetcaiman September 25, 2026 17:26

fix: failing wpt tests

c8578e3

closetcaiman reviewed Sep 25, 2026

View reviewed changes

refactor: renaming for much clearer view on channel negotiation

62ee6bf

github-actions Bot added the conflicts This PR has conflicts with the base branch. label Sep 29, 2026

Merge branch 'main' into refactor/delay-convolver-wpt-improvements

524d440

github-actions Bot removed the conflicts This PR has conflicts with the base branch. label Sep 29, 2026

Navigation Menu

Uh oh!

refactor: changes for the wpt convolver and delay - #1308

refactor: changes for the wpt convolver and delay#1308
mdydek wants to merge 5 commits into
mainfrom
refactor/delay-convolver-wpt-improvements

mdydek commented Sep 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

closetcaiman Sep 25, 2026

Uh oh!

closetcaiman Sep 25, 2026

Uh oh!

mdydek Sep 27, 2026

Uh oh!

closetcaiman Sep 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mdydek commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WPT non-regression comparison

Uh oh!

closetcaiman Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

closetcaiman Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

mdydek Sep 27, 2026

Choose a reason for hiding this comment

Uh oh!

closetcaiman Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mdydek commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading