Skip to content

refactor: more complex refactors connecting with convolver and delay - #1309

Draft
mdydek wants to merge 1 commit into
refactor/delay-convolver-wpt-improvementsfrom
refactor/delay-convolver-wpt-improvements-part2
Draft

mdydek wants to merge 1 commit into
refactor/delay-convolver-wpt-improvementsfrom
refactor/delay-convolver-wpt-improvements-part2

Conversation

@mdydek

@mdydek mdydek commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

NOT FINISHED, but left draft so that full ci runs

Needs to be finished after #1302

⚠️ Breaking changes ⚠️

Introduced changes

  • convolver needs to handle changing input channel count or changing channel count of impulse response, thus returning different number of channels
  • if the delay is a part of cycle, clamp the delayTime to minimum of RQS

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@mdydek
mdydek added this pull request to stack #1310 September 24, 2026 11:37
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

WPT non-regression comparison

PASS — no regressions · 3 improved section(s) · overall 2718 → 2789 (+71)

Spec section Base pass Head pass Delta
Processing model 1 2 +1
ConvolverNode 178 245 +67
DelayNode 127 130 +3
Unchanged sections (25)
Spec section Base pass Head pass Delta
Other 52 52 0
AnalyserNode 138 138 0
AudioBuffer 140 140 0
AudioBufferSourceNode 218 218 0
AudioContext 58 58 0
AudioNode 261 261 0
AudioParam 629 629 0
BiquadFilterNode 275 275 0
ChannelMergerNode 30 30 0
ChannelSplitterNode 7 7 0
ConstantSourceNode 64 64 0
DestinationNode 0 0 0
DynamicsCompressorNode 4 4 0
GainNode 15 15 0
IIRFilterNode 87 87 0
MediaElementAudioSourceNode 0 0 0
MediaStreamAudioDestinationNode 1 1 0
MediaStreamAudioSourceNode 0 0 0
OfflineAudioContext 35 35 0
OscillatorNode 104 104 0
PannerNode 75 75 0
PeriodicWave 33 33 0
ScriptProcessorNode 0 0 0
StereoPannerNode 104 104 0
WaveShaperNode 82 82 0

Baseline: 20f7019368cda36d6acd4b2a69860a4656dfbbe0 · Candidate: 1ff837f0fd54f032328db4839ee024d25ff33549

Workflow run · this comment is updated on every push.

@mdydek
mdydek force-pushed the refactor/delay-convolver-wpt-improvements-part2 branch 2 times, most recently from dce0322 to 2068f4c Compare September 24, 2026 14:36
@github-actions github-actions Bot added the conflicts This PR has conflicts with the base branch. label Sep 24, 2026
@mdydek
mdydek force-pushed the refactor/delay-convolver-wpt-improvements-part2 branch from 2068f4c to 1ff837f Compare September 24, 2026 14:37
@github-actions github-actions Bot removed the conflicts This PR has conflicts with the base branch. label Sep 24, 2026
@closetcaiman closetcaiman added the refactor Code restructuring without altering external behavior or fixing bugs label Sep 24, 2026
@mdydek
mdydek marked this pull request as draft September 28, 2026 13:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code restructuring without altering external behavior or fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants