Skip to content

fix(ios): return frame-count duration from IOSFileWriter::closeFile #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdydek merged 2 commits into from
Sep 25, 2026
Merged

fix(ios): return frame-count duration from IOSFileWriter::closeFile #1320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03b9ec8
fix(ios): return frame-count duration from IOSFileWriter::closeFile
canbal Sep 24, 2026
6441d04
fix: cleanup comments
mdydek Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/react-native-audio-api/ios/audioapi/ios/core/utils/IOSFileWriter.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@
}

/// @brief Closes the currently open audio file and finalizes writing.
/// This method retrieves the final file duration and size before closing.
/// This method should be called from the JS thread only.
/// @returns A CloseFileResult indicating success with file duration and size or an error message.
CloseFileResult IOSFileWriter::closeFile()
Expand All @@ -203,8 +202,7 @@
// AVAudioFile automatically finalizes the file when deallocated
audioFile_ = nil;

double fileDuration = CMTimeGetSeconds([[AVURLAsset URLAssetWithURL:fileURL_
options:nil] duration]);
double fileDuration = getCurrentDuration();
double fileSizeBytesMb = static_cast<double>([[[NSFileManager defaultManager]
attributesOfItemAtPath:fileURL_.path
error:&error] fileSize]) /
Expand Down
Loading