π fix: μ± λ΄ κ²μκΈ μμ νμΈμ°½ λμ μμ - #633
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: π Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Walkthroughκ²μκΈ μμ νλ¦μ μ€λ₯ μλ¦Όκ³Ό μ¬μ©μ νμΈ μ μ°¨λ₯Ό μΆκ°νμ΅λλ€. μμ μ§ν μ€μλ μμ λ²νΌμ λΉνμ±νν©λλ€.
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: βͺ Minimal Β· up to κ²μκΈ μμ νμΈ νλ¦μ κ³΅ν΅ λͺ¨λ¬λ‘ λ³κ²½νκ³ νμ μμλ§ μμ APIλ₯Ό νΈμΆνλλ‘ μ 리νμ΅λλ€. μ€μ²© νμΈ νΈμΆμμ λκΈ° μ€μΈ Promiseκ° λ¨μ μ μμ§λ§ μμ API μ€λ³΅ νΈμΆμ΄λ ꡬ체μ μΈ μ¬μ©μ μ₯μ λ‘ μ΄μ΄μ§λ€λ κ·Όκ±°λ μμ΄, μΌλ°μ μΈ νμΈ ν λ³ν© κ°λ₯ν μ΅μ μν μμ€μ λλ€. Suggested reviewers: π₯ Pre-merge checks | β 5β Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33bed9b7cb
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onError: () => { | ||
| showIconToast("logo", "κ²μκΈ μμ μ μ€ν¨νμ΅λλ€. μ μ ν λ€μ μλν΄μ£ΌμΈμ."); | ||
| }, |
There was a problem hiding this comment.
Suppress the global error toast for this mutation
When the delete request fails with a non-401 Axios error, MutationCache.onError in apps/web/src/lib/react-query/queryClient.ts already calls showIconToast, and this callback emits another toast with a usually different message. Because toast deduplication uses the icon and message together, users receive two failure notifications for one request; either set meta: SKIP_GLOBAL_ERROR_TOAST_META on this mutation or rely solely on the global handler.
Useful? React with πΒ / π.
κ΄λ ¨ μ΄μ
μμ λ΄μ©
confirm()μ νλ‘μ νΈ κ³΅ν΅ νμΈ λͺ¨λ¬λ‘ κ΅μ²΄νμ΅λλ€.κ²μ¦
pnpm --filter @solid-connect/web run ci:checkν΅κ³Όgit diff --checkν΅κ³ΌνΉμ΄ μ¬ν
리뷰 μꡬμ¬ν (μ ν)