Skip to content

πŸ› fix: μ•± λ‚΄ κ²Œμ‹œκΈ€ μ‚­μ œ 확인창 λ™μž‘ μˆ˜μ • - #633

Merged
manNomi merged 1 commit into
mainfrom
fix/community-post-delete-button
Sep 1, 2026
Merged

πŸ› fix: μ•± λ‚΄ κ²Œμ‹œκΈ€ μ‚­μ œ 확인창 λ™μž‘ μˆ˜μ •#633
manNomi merged 1 commit into
mainfrom
fix/community-post-delete-button

Conversation

@manNomi

@manNomi manNomi commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

κ΄€λ ¨ 이슈

  • μ‚¬μš©μž 제보: μ•±μ—μ„œ κ²Œμ‹œκΈ€ μ‚­μ œ λ²„νŠΌμ΄ λ™μž‘ν•˜μ§€ μ•ŠμŒ

μž‘μ—… λ‚΄μš©

  • WebViewμ—μ„œ λ™μž‘μ΄ 보μž₯λ˜μ§€ μ•ŠλŠ” λΈŒλΌμš°μ € κΈ°λ³Έ confirm()을 ν”„λ‘œμ νŠΈ 곡톡 확인 λͺ¨λ‹¬λ‘œ κ΅μ²΄ν–ˆμŠ΅λ‹ˆλ‹€.
  • μ‚­μ œ 확인 μ „ λ“œλ‘­λ‹€μš΄μ„ λ‹«κ³  μ‚¬μš©μžκ°€ μ‚­μ œλ₯Ό ν™•μ •ν–ˆμ„ λ•Œλ§Œ APIλ₯Ό ν˜ΈμΆœν•˜λ„λ‘ μ •λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€.
  • μ‚­μ œ 처리 쀑 쀑볡 μš”μ²­μ„ 막고 API μ‹€νŒ¨ μ‹œ 였λ₯˜ ν† μŠ€νŠΈλ₯Ό ν‘œμ‹œν•˜λ„λ‘ λ³΄μ™„ν–ˆμŠ΅λ‹ˆλ‹€.

검증

  • Node.js 22.20.0
  • pnpm --filter @solid-connect/web run ci:check 톡과
  • git diff --check 톡과

특이 사항

  • μ‚­μ œ API와 성곡 ν›„ λͺ©λ‘ 이동 κ²½λ‘œλŠ” λ³€κ²½ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

리뷰 μš”κ΅¬μ‚¬ν•­ (선택)

  • μ•± WebViewμ—μ„œ 곡톡 확인 λͺ¨λ‹¬μ˜ μ·¨μ†Œμ™€ μ‚­μ œ ν™•μ • 흐름을 μ€‘μ‹¬μœΌλ‘œ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.

@manNomi
manNomi requested a review from wibaek as a code owner September 1, 2026 14:25
@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
solid-connect-university-web Ready Ready Preview Sep 1, 2026 2:28pm UTC
solid-connection-web Ready Ready Preview Sep 1, 2026 2:28pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
solid-connect-web-admin Skipped Skipped Sep 1, 2026 2:28pm UTC

@github-actions github-actions Bot added the web label Sep 1, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-09-01T14:28:10.115436Z 33bed9b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 16278da5-d65b-4a08-9d6d-47416f5b949a

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 03e914b and 33bed9b.

πŸ“’ Files selected for processing (2)
  • apps/web/src/apis/community/deletePost.ts
  • apps/web/src/app/community/[boardCode]/[postId]/KebabMenu.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

κ²Œμ‹œκΈ€ μ‚­μ œ 흐름에 였λ₯˜ μ•Œλ¦Όκ³Ό μ‚¬μš©μž 확인 절차λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. μ‚­μ œ μ§„ν–‰ μ€‘μ—λŠ” μ‚­μ œ λ²„νŠΌμ„ λΉ„ν™œμ„±ν™”ν•©λ‹ˆλ‹€.

  1. μ‚­μ œ μ‹€νŒ¨ 처리

    • μ‚­μ œ μ‹€νŒ¨ μ‹œ μ•ˆλ‚΄ ν† μŠ€νŠΈλ₯Ό ν‘œμ‹œν•©λ‹ˆλ‹€.
  2. μ‚­μ œ 확인 및 μ§„ν–‰ μƒνƒœ

    • λΈŒλΌμš°μ € κΈ°λ³Έ 확인창 λŒ€μ‹  customConfirm λͺ¨λ‹¬μ„ μ‚¬μš©ν•©λ‹ˆλ‹€.
    • μ‚­μ œκ°€ μ§„ν–‰λ˜λŠ” λ™μ•ˆ λ²„νŠΌμ„ λΉ„ν™œμ„±ν™”ν•©λ‹ˆλ‹€.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: βšͺ Minimal Β· up to 33bed

κ²Œμ‹œκΈ€ μ‚­μ œ 확인 흐름을 곡톡 λͺ¨λ‹¬λ‘œ λ³€κ²½ν•˜κ³  ν™•μ • μ‹œμ—λ§Œ μ‚­μ œ APIλ₯Ό ν˜ΈμΆœν•˜λ„λ‘ μ •λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€. 쀑첩 확인 ν˜ΈμΆœμ—μ„œ λŒ€κΈ° 쀑인 Promiseκ°€ 남을 수 μžˆμ§€λ§Œ μ‚­μ œ API 쀑볡 ν˜ΈμΆœμ΄λ‚˜ ꡬ체적인 μ‚¬μš©μž μž₯μ• λ‘œ μ΄μ–΄μ§„λ‹€λŠ” κ·Όκ±°λŠ” μ—†μ–΄, 일반적인 확인 ν›„ 병합 κ°€λŠ₯ν•œ μ΅œμ†Œ μœ„ν—˜ μˆ˜μ€€μž…λ‹ˆλ‹€.

Suggested reviewers: wibaek, enunsnv, khwww

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Title check βœ… Passed 제λͺ©μ€ κ²Œμ‹œκΈ€ μ‚­μ œ 확인창 λ™μž‘ μˆ˜μ •μ΄λΌλŠ” 핡심 변경을 λͺ…ν™•ν•˜κ²Œ μ„€λͺ…ν•©λ‹ˆλ‹€. λ³€κ²½ λ‚΄μš©κ³Ό 직접 κ΄€λ ¨λ˜λ©° κ°„κ²°ν•©λ‹ˆλ‹€.
Description check βœ… Passed μ„€λͺ…은 κ΄€λ ¨ 이슈, μž‘μ—… λ‚΄μš©, 검증 κ²°κ³Ό, 특이 사항, 리뷰 μš”κ΅¬μ‚¬ν•­μ„ ν¬ν•¨ν•©λ‹ˆλ‹€. κΈ°λ³Έ confirm() ꡐ체, 쀑볡 μš”μ²­ λ°©μ§€, 였λ₯˜ ν† μŠ€νŠΈ μΆ”κ°€λ₯Ό ꡬ체적으둜 μ„€λͺ…ν•©λ‹ˆλ‹€.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
πŸ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/community-post-delete-button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33bed9b7cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +62 to +64
onError: () => {
showIconToast("logo", "κ²Œμ‹œκΈ€ μ‚­μ œμ— μ‹€νŒ¨ν–ˆμŠ΅λ‹ˆλ‹€. μž μ‹œ ν›„ λ‹€μ‹œ μ‹œλ„ν•΄μ£Όμ„Έμš”.");
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Suppress the global error toast for this mutation

When the delete request fails with a non-401 Axios error, MutationCache.onError in apps/web/src/lib/react-query/queryClient.ts already calls showIconToast, and this callback emits another toast with a usually different message. Because toast deduplication uses the icon and message together, users receive two failure notifications for one request; either set meta: SKIP_GLOBAL_ERROR_TOAST_META on this mutation or rely solely on the global handler.

Useful? React with πŸ‘Β / πŸ‘Ž.

@manNomi
manNomi merged commit ef4c1d5 into main Sep 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant