Skip to content

feat: 지원자 현황 경쟁자 API 전환 - #636

Merged
whqtker merged 1 commit into
mainfrom
whqtker/feat-applications-competitors-filter
Sep 2, 2026
Merged

feat: 지원자 현황 경쟁자 API 전환#636
whqtker merged 1 commit into
mainfrom
whqtker/feat-applications-competitors-filter

Conversation

@whqtker

@whqtker whqtker commented Sep 2, 2026

Copy link
Copy Markdown
Member

변경 내용

  • 지원자 현황 조회를 GET /applications/competitors로 전환했습니다.
  • 기간 종료 후 GET /applications로 되돌릴 수 있도록 기존 소속 대학 필터를 보존했습니다.

검증

  • pnpm --filter @solid-connect/web ci:check
  • pnpm --filter @solid-connect/web build

관련 이슈

  • 없음

@whqtker whqtker self-assigned this Sep 2, 2026
@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
solid-connect-university-web Ready Ready Preview Sep 2, 2026 12:48pm UTC
solid-connection-web Ready Ready Preview Sep 2, 2026 12:48pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
solid-connect-web-admin Skipped Skipped Sep 2, 2026 12:48pm UTC

@github-actions github-actions Bot added the web label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 52b77111-cd41-4a67-9ae8-535bf170ddf7

📥 Commits

Reviewing files that changed from the base of the PR and between ad3d14f and 326bed4.

📒 Files selected for processing (4)
  • apps/web/src/apis/applications/api.ts
  • apps/web/src/apis/applications/getApplicants.ts
  • apps/web/src/apis/applications/getCompetitors.ts
  • apps/web/src/apis/applications/homeUniversityScope.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

  1. 경쟁자 API 응답 계약 변경
    getCompetitors가 요청 파라미터 없이 AxiosResponse<ApplicationListResponse>를 반환합니다.

  2. 경쟁자 조회 훅 변경
    useGetCompetitorsUseQueryOptions를 받고 응답 데이터만 선택합니다.

  3. 애플리케이션 상태 조회 경로 변경
    useGetApplicationsListcompetitors 엔드포인트를 사용합니다. applications 엔드포인트에서만 홈 대학 범위 필터를 적용합니다. 관련 주석도 수정했습니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 326be

This PR switches applicant-status retrieval to the competitors endpoint while preserving the existing university filter for fallback behavior; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 제목은 지원자 현황 조회를 경쟁자 API로 전환하는 주요 변경을 정확하고 간결하게 설명합니다.
Description check ✅ Passed 설명은 API 전환, 기존 소속 대학 필터 보존, 검증 명령을 포함합니다. 템플릿의 '작업 내용'과 '특이 사항' 제목은 사용하지 않았지만 핵심 정보는 대부분 제공되었습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch whqtker/feat-applications-competitors-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@whqtker
whqtker merged commit eb77bd5 into main Sep 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants