Skip to content

Fix GitHub Actions workflow#322

Merged
solid-illiaaihistov merged 9 commits into
solid-software:analysis_server_migrationfrom
solid-illiaaihistov:307-format-all-project
Jul 22, 2026
Merged

Fix GitHub Actions workflow#322
solid-illiaaihistov merged 9 commits into
solid-software:analysis_server_migrationfrom
solid-illiaaihistov:307-format-all-project

Conversation

@solid-illiaaihistov

@solid-illiaaihistov solid-illiaaihistov commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Closes #307

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 20, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on code formatting, cleanup, and restructuring, including the removal of the redundant solid_lints_test project and the relocation of test utility files. Feedback on the changes highlights two key improvements: addressing a potential runtime TypeError in avoid_using_api_parameters.dart when json['entries'] is null, and replacing a generic Exception with a more specific FormatException in named_type_utils.dart.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/src/lints/avoid_using_api/models/avoid_using_api_parameters.dart
Comment thread lib/src/utils/named_type_utils.dart Outdated
danylo-safonov-solid
danylo-safonov-solid approved these changes Jul 21, 2026
View reviewed changes

@danylo-safonov-solid danylo-safonov-solid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, otherwise LGTM

Comment thread lib/src/lints/no_empty_block/no_empty_block_rule.dart Outdated
@solid-illiaaihistov
solid-illiaaihistov merged commit d9f8964 into solid-software:analysis_server_migration Jul 22, 2026
1 check passed
@solid-illiaaihistov
solid-illiaaihistov deleted the 307-format-all-project branch July 22, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
@danylo-safonov-solid danylo-safonov-solid danylo-safonov-solid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@solid-illiaaihistov @danylo-safonov-solid