Fix animation state bugs and restructure the engine - #1
Merged
davedbase merged 4 commits intoSep 5, 2026
Annotations
2 errors, 2 warnings, and 1 notice
|
Run Playwright tests:
e2e/animate.spec.ts#L11
1) [webkit] › e2e/animate.spec.ts:5:2 › animate › animates from initial to the animate target ────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toBeCloseTo(expected, precision)
Expected: 1
Received: 0.021363
Expected precision: 1
Expected difference: < 0.05
Received difference: 0.978637
9 | // starts at the initial target rather than jumping to animate
10 | expect(await opacity(box)).toBeLessThan(1)
> 11 | expect(Number(await settled(box))).toBeCloseTo(1, 1)
| ^
12 | })
13 |
14 | test("initial={false} applies the animate target with no transition", async ({page}) => {
at /home/runner/work/solid-motion/solid-motion/e2e/animate.spec.ts:11:38
|
|
Run Playwright tests:
e2e/animate.spec.ts#L11
1) [webkit] › e2e/animate.spec.ts:5:2 › animate › animates from initial to the animate target ────
Error: expect(received).toBeCloseTo(expected, precision)
Expected: 1
Received: 0
Expected precision: 1
Expected difference: < 0.05
Received difference: 1
9 | // starts at the initial target rather than jumping to animate
10 | expect(await opacity(box)).toBeLessThan(1)
> 11 | expect(Number(await settled(box))).toBeCloseTo(1, 1)
| ^
12 | })
13 |
14 | test("initial={false} applies the animate target with no transition", async ({page}) => {
at /home/runner/work/solid-motion/solid-motion/e2e/animate.spec.ts:11:38
|
|
Complete job
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, actions/upload-artifact@v4, pnpm/action-setup@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Run actions/upload-artifact@v4
No files were found with the provided path: playwright-report/. No artifacts will be uploaded.
|
|
Run Playwright tests
1 flaky
[webkit] › e2e/animate.spec.ts:5:2 › animate › animates from initial to the animate target ─────
95 passed (1.7m)
|
background
wait
wait-all
cancel
parallel
Loading