Skip to content

feat(upload/transformFiles): remove unnecessary validation #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
an-jello wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −19
Open

feat(upload/transformFiles): remove unnecessary validation #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c46aa
fix(upload/transformFiles): remove unnecessary validation
an-jello Sep 9, 2026
04c31ee
chore: changeset for changelog
an-jello Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fine-kids-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solid-primitives/upload": patch
---

`helper`: rework `transformFiles` internal function to remove unneeded checks
29 changes: 10 additions & 19 deletions packages/upload/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,29 +14,20 @@ export function createInputComponent({ multiple = false, accept = "" }: FileUplo
}

export function transformFiles(files: FileList | null): UploadFile[] {
const parsedFiles: UploadFile[] = [];

if (!files) return parsedFiles;

for (const index in files) {
const fileIndex = +index;
if (isNaN(+fileIndex)) {
continue;
}

const file = files[fileIndex];
if (!file) {
continue;
}

const parsedFile: UploadFile = {
if (!files) return [];

const parsed: UploadFile[] = []
for (const idx in files) {
// SAFETY: w3c File API defines FileList item access to be valid from index 0 to `files.length - 1`
// https://w3c.github.io/FileAPI/#filelist-methods-params: "Supported property indices are the numbers in the range zero to one less than the number of File objects represented by the FileList object."
const file = files[Number(idx)]!
parsed.push({
source: URL.createObjectURL(file),
name: file.name,
size: file.size,
file,
};
parsedFiles.push(parsedFile);
});
}

return parsedFiles;
return parsed;
}