Repository navigation
fix: let a navigation back to the shown route cancel a pending one - #719
Open
thelastbackspace wants to merge 1 commit into
Open
thelastbackspace wants to merge 1 commit into
thelastbackspace wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 4ef6e82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a navigation to a slow route was pending, navigating back to the route still on screen was ignored, and the slow route showed up once its data resolved.
navigateFromRoutecompared the new target againstreference(), which still points at the shown route while the transition is pending, so/alooked like a no-op and never reachedtransition(). It now compares against the pending target when there is one. Since that navigation ends where it started,navigateEndalso skipssetSourcewhen the final location and state equal the first referrer, otherwise a second/ahistory entry gets pushed.referrersis still cleared either way.Navigating to the same route with fresh state still pushes an entry like before, since the state actually changes.
Added
test/pending-navigation.spec.tsx: starting on/a, navigate to a route behind an unresolved resource, navigate back to/a, resolve the resource, and check that/ais still shown and Back goes to/(no duplicate entry). It fails on main withexpected '/slow' to be '/a'and passes with the change.vitest run, the SSR config andtsc -p tsconfig.test.jsonpass locally. Added a patch changeset.Fixes #714