Skip to content

ci(1.x): bump cypress-io/github-action to v7 - #2369

Merged
birkskyum merged 1 commit into
1.xfrom
fix/1.x-cypress-action-v7
Nov 1, 2026
Merged

birkskyum merged 1 commit into
1.xfrom
fix/1.x-cypress-action-v7

Conversation

@birkskyum

Copy link
Copy Markdown
Member

The 🧪 Tests workflow on `1.x` has failed on every run since the GitHub runner moved to 2.338.0 (for example the release PR #2367).

Cause

Runner 2.338.0 bundles Node 24.21.0, and the deprecated node20 actions are forced to run on it. On Node >=24.20, the `wait-on` ping in `cypress-io/github-action@v6` (built on got@11) fails immediately with `ERR_SOCKET_CLOSED_BEFORE_CONNECTION`. Before, it got `ECONNREFUSED` and retried until the test server came up. So E2E Chromium fails about 15ms after the step starts, before the server is listening:

waiting on "http://127.0.0.1:3000" with timeout of 120 seconds
##[error]Socket closed before the connection was established

Upstream issue: cypress-io/github-action#1873, fixed in v7.4.4 by moving to got@16.

Change

Bump both E2E steps from `cypress-io/github-action@v6` to `@v7`. The only breaking change in v7.0.0 is that the action itself runs on node24. `main` doesn't use this action, so only `1.x` needs this.

Once this merges, the changesets bot should regenerate #2367 from the new `1.x` head, and its CI should go green.

GitHub runner 2.338.0 bundles Node 24.21.0. Under Node >=24.20 the v6
action's wait-on ping (got@11) fails immediately with
ERR_SOCKET_CLOSED_BEFORE_CONNECTION instead of retrying until the test
server is up, so E2E Chromium fails before Cypress starts.

v7.4.4+ moved to got@16, which retries on that error. The only breaking
change in v7 is running the action on node24.

See cypress-io/github-action#1873.
@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ed38586

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@birkskyum
birkskyum requested a review from brenelz November 1, 2026 23:49
@pkg-pr-new

pkg-pr-new Bot commented Nov 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2369

commit: ed38586

@birkskyum
birkskyum merged commit 4a776cc into 1.x Nov 1, 2026
7 checks passed
@birkskyum
birkskyum deleted the fix/1.x-cypress-action-v7 branch November 1, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant