Repository navigation
ci(1.x): bump cypress-io/github-action to v7 - #2369
Merged
Merged
Conversation
GitHub runner 2.338.0 bundles Node 24.21.0. Under Node >=24.20 the v6 action's wait-on ping (got@11) fails immediately with ERR_SOCKET_CLOSED_BEFORE_CONNECTION instead of retrying until the test server is up, so E2E Chromium fails before Cypress starts. v7.4.4+ moved to got@16, which retries on that error. The only breaking change in v7 is running the action on node24. See cypress-io/github-action#1873.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 🧪 Tests workflow on `1.x` has failed on every run since the GitHub runner moved to 2.338.0 (for example the release PR #2367).
Cause
Runner 2.338.0 bundles Node 24.21.0, and the deprecated node20 actions are forced to run on it. On Node >=24.20, the `wait-on` ping in `cypress-io/github-action@v6` (built on got@11) fails immediately with `ERR_SOCKET_CLOSED_BEFORE_CONNECTION`. Before, it got `ECONNREFUSED` and retried until the test server came up. So E2E Chromium fails about 15ms after the step starts, before the server is listening:
Upstream issue: cypress-io/github-action#1873, fixed in v7.4.4 by moving to got@16.
Change
Bump both E2E steps from `cypress-io/github-action@v6` to `@v7`. The only breaking change in v7.0.0 is that the action itself runs on node24. `main` doesn't use this action, so only `1.x` needs this.
Once this merges, the changesets bot should regenerate #2367 from the new `1.x` head, and its CI should go green.