Repository navigation
Conversation
Calls that send files (`X-Start-Type: 8`) fell through to the generic multipart viewer, which showed the arguments as one raw string and the files apart from them. The request viewer now shows the arguments as a Seroval tree, and each upload node shows its file part with the type, name and last modified time the node holds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 1dbceae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
brenelz
reviewed
Nov 3, 2026
| /** | ||
| * Shows a call that sent files: the arguments from the `ARGS_PART` field as a | ||
| * Seroval tree, with each upload in the tree replaced by its file part. | ||
| */ |
Contributor
There was a problem hiding this comment.
does solid start have its own dev-toolbar. I kinda forget if the other package is just 2.0 or not
Member
Author
There was a problem hiding this comment.
yes. Solid 2.0 have it separated now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls that send files (
X-Start-Type: 8, added in #2359) had no case in the dev toolbar's body viewer. They fell through to the generic multipart viewer, which showed:argsfield as one escaped raw string instead of a Seroval tree;file<i>parts apart from the arguments, with the part's type instead of the file's.Changes
functions/index.tsx: aBodyFormat.SerovalFormDatacase reads the form, showsargswithSerovalViewer, and passes the form asuploads. It falls back toFormDataViewerifargsis missing.functions/SerovalViewer.tsx: an optionaluploadsprop. A plugin node taggedsolid-start/uploadshows aBlobViewerfor its part, with the type, name and last modified time from the node (fix(start): keep file and blob metadata in server function uploads #2370), as the server deserializer does. Nodes without metadata show the part as it is.fns/uploads.ts: exportsUPLOAD_TAG.Testing
pnpm typecheckandpnpm validate-importsinpackages/start.apps/testsand opened theserver-function-uploadcall in the toolbar.hello-world.txt(no type), the two attachment blobs andavatar.png(image/png) inside theFormDataargument all show in place.🤖 Generated with Claude Code