Skip to content

ci: Remove link check from Vercel build, keep in PR check - #1960

Merged
marcleblanc2 merged 1 commit into
mainfrom
marc/build/no-link-check
Sep 17, 2026
Merged

marcleblanc2 merged 1 commit into
mainfrom
marc/build/no-link-check

Conversation

@marcleblanc2

@marcleblanc2 marcleblanc2 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor
  • The dev/check-links.mjs script is used in the Check links PR check
  • Amp had also added it to the Vercel build, which wasn't intended, and is duplicative, so removing it

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sourcegraph-docs Ready Ready Preview Sep 17, 2026 12:28am UTC

Request Review

@marcleblanc2 marcleblanc2 changed the title build: drop the link check from the Vercel build; it runs as its own PR check ci: Remove the link check from the Vercel build Sep 15, 2026
@marcleblanc2
marcleblanc2 enabled auto-merge (squash) September 15, 2026 17:35
@marcleblanc2
marcleblanc2 requested a review from a team September 15, 2026 17:35
@marcleblanc2 marcleblanc2 changed the title ci: Remove the link check from the Vercel build ci: Remove link check from Vercel build, keep in PR check Sep 15, 2026
@marcleblanc2
marcleblanc2 enabled auto-merge (squash) September 15, 2026 17:36
…PR check

The Broken links introduced by this PR job (.github/workflows/check-links.yml)
runs dev/check-links.mjs on every pull request, with a baseline so it only
reports links the PR introduces, and comments the findings. Running it again
without flags in npm run build duplicated that check and made a dead link
anywhere in the tree fail the deploy, even one not introduced by the commit.

npm run build now runs only the filenames and images checks. npm run check
still runs all three.

Amp-Thread-ID: https://ampcode.com/threads/T-01a09f23-2ad6-76a8-a697-3da4969f29f9
Co-authored-by: Amp <amp@ampcode.com>
@marcleblanc2
marcleblanc2 force-pushed the marc/build/no-link-check branch from 1440f0e to f1b1846 Compare September 17, 2026 00:26
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Spell check found 1 issue(s) in this PR

Only findings on lines added by this PR, and in its title and description, are shown.

Pull request description

  • line 2, column 76
    • duplicativeduplicate

Please correct the spelling, or add words which are correct to cspell-allow-list.txt.

Run npx cspell@10 --no-progress --dot '**/*' locally to check the full repository.

@marcleblanc2
marcleblanc2 merged commit e0407d4 into main Sep 17, 2026
6 checks passed
@marcleblanc2
marcleblanc2 deleted the marc/build/no-link-check branch September 17, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants