Remove dependencies nothing imports and stale RSS .gitignore entries - #1987
Closed
marcleblanc2 wants to merge 1 commit into
Closed
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
None of these packages are imported by src/, dev/, or any config file: @docsearch/react (only its CSS is vendored), @mdx-js/mdx, date-fns, fast-glob, feed, prism-react-renderer, react-highlight-words and its @types, react-syntax-highlighter, rehype-toc, simple-functional-loader, dotenv. public/changelog.rss and public/technical-changelog.rss are no longer generated here: the feed is served from sourcegraph.com (see src/data/constants.ts) and src/proxy.ts redirects to it. Amp-Thread-ID: https://ampcode.com/threads/T-01a0ad56-bd79-73ce-bc8e-a5405d0c11f2 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Merged
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm removeof every package inpackage.jsonwith no import insrc/,dev/, or any config file:@docsearch/react(only its CSS is vendored insrc/components/search/docsearch/),@mdx-js/mdx,date-fns,fast-glob,feed,prism-react-renderer,react-highlight-words+@types/react-highlight-words,react-syntax-highlighter,rehype-toc,simple-functional-loader,dotenv.Kept on purpose:
shiki(peer dependency ofrehype-pretty-code) andsharp(Next.js image optimisation).Also drops the
.gitignoreentries forpublic/changelog.rssandpublic/technical-changelog.rss. Nothing generates them any more: the feed comes from sourcegraph.com (src/data/constants.ts) andsrc/proxy.tsredirects the old paths to it.Test plan
pnpm run buildexit 0npx tsc --noEmitclean;pnpm run lint0 errorspnpm startand requested/,/cody/quickstart,/api/versions: all 200