a11y: Fix text contrast below WCAG AA - #1995
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
This comment has been minimized.
This comment has been minimized.
marcleblanc2
changed the title
marcleblanc2
marked this pull request as ready for review
September 17, 2026 09:09
burmudar
approved these changes
Sep 17, 2026
marcleblanc2
enabled auto-merge (squash)
September 17, 2026 09:56
axe-core color-contrast violations (serious), with the ratio on the page background before and after: - Bold text in light mode: vermilion-08 #FF7867 (2.5:1) to a new vermilion-05 #B80000 (6.8:1). Dark mode keeps vermilion-08 (7.7:1) - Active breadcrumb, TOC entry and sidebar link (link.light token): vermilion-07 #F34E3F (3.4:1) to vermilion-06 #DA251B (4.8:1) - Breadcrumb links in dark mode: gray-500 (4.3:1) to gray-400 (8.2:1) - Search button placeholder in dark mode: slate-500 (4.2:1) to slate-400 (7.8:1) - Search shortcut hint: slate-400 (2.5:1) to slate-500 (4.7:1) in light mode, slate-600 (2.6:1) to slate-400 (7.8:1) in dark mode Also corrects the link token comments, which said Teal for Vermilion values. Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae7e-ae2c-7423-be36-eb9c5884b1e0 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae7e-ae2c-7423-be36-eb9c5884b1e0 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/a11y/color-contrast
branch
from
September 17, 2026 10:09
5f4a2a7 to
1779a37
Compare
Contributor
Author
|
From the docs site audit (crawl of all 502 pages). One contrast finding this PR did not cover: the code-comment colour in the syntax theme, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
axe-core flags
color-contrastviolations (impact: serious) on every page: 13 on the home page in light mode, plus more on docs pages and in dark mode. WCAG AA needs 4.5:1 for body-size text.Fix
Ratios are against the page background (
#fffcfclight,#060000/#0e0808dark).Prose.tsx)#FF7867, 2.5:1#B80000, 6.8:1link.lighttoken)#F34E3F, 3.4:1#DA251B, 4.8:1Vermilion-05 and -06 are the values from
client/web/src/SourcegraphWebApp.scssinsourcegraph/sourcegraph. Also fixes thelinktoken comments intailwind.config.ts, which said Teal for Vermilion values.Verification
axe-core 4.12 via Playwright against a local
next dev, on/and/admin/audit-log, light and dark:color-contrastgoes from 13 / 1 / 2 / 2 nodes to 0 on all four.Bold text before and after, light mode:
rgb(255, 120, 103)coralrgb(184, 0, 0)redPart of a set of three a11y PRs; the other two fix
button-nameandlandmark-one-main/region.